chenboat commented on code in PR #15234:
URL: https://github.com/apache/pinot/pull/15234#discussion_r2002274863
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -1093,6 +1093,35 @@ public void segmentStoppedConsuming(LLCSegmentName
llcSegmentName, String instan
}
}
+ /**
+ * An instance is reporting that it cannot build segment due to
non-recoverable error, usually due to size too large.
+ * Reduce the segment "segment.flush.threshold.size" to its half value.
Review Comment:
nit: ... to half of the current segment size target.
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -1093,6 +1093,35 @@ public void segmentStoppedConsuming(LLCSegmentName
llcSegmentName, String instan
}
}
+ /**
+ * An instance is reporting that it cannot build segment due to
non-recoverable error, usually due to size too large.
+ * Reduce the segment "segment.flush.threshold.size" to its half value.
Review Comment:
nit: ... to half of the current segment size target.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
