chenboat commented on code in PR #15234:
URL: https://github.com/apache/pinot/pull/15234#discussion_r2002278498
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -1093,6 +1093,35 @@ public void segmentStoppedConsuming(LLCSegmentName
llcSegmentName, String instan
}
}
+ /**
+ * An instance is reporting that it cannot build segment due to
non-recoverable error, usually due to size too large.
Review Comment:
When one server fails to build the segment and the controller updates the
segment size target to half of the previous value, how will the other replica
servers handle such change? Will they continue to build? There are two cases:
(1)if they also have the same build failure, they will reset their target? (2)
What happen if they build the segments successfully?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
