r-reis commented on code in PR #15273: URL: https://github.com/apache/pinot/pull/15273#discussion_r2002119762
########## pinot-plugins/pinot-input-format/pinot-confluent-json/src/main/java/org/apache/pinot/plugin/inputformat/json/confluent/KafkaConfluentSchemaRegistryJsonMessageDecoder.java: ########## @@ -0,0 +1,153 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.plugin.inputformat.json.confluent; + +import com.fasterxml.jackson.databind.JsonNode; +import com.google.common.base.Preconditions; +import io.confluent.kafka.schemaregistry.client.CachedSchemaRegistryClient; +import io.confluent.kafka.schemaregistry.client.SchemaRegistryClient; +import io.confluent.kafka.schemaregistry.client.rest.RestService; +import io.confluent.kafka.schemaregistry.json.JsonSchemaProvider; +import io.confluent.kafka.serializers.json.KafkaJsonSchemaDeserializer; +import java.util.Arrays; +import java.util.Collections; +import java.util.HashMap; +import java.util.Map; +import java.util.Set; +import org.apache.kafka.common.config.ConfigDef; +import org.apache.kafka.common.config.SslConfigs; +import org.apache.kafka.common.config.types.Password; +import org.apache.kafka.common.errors.SerializationException; +import org.apache.kafka.common.security.ssl.DefaultSslEngineFactory; +import org.apache.pinot.plugin.inputformat.json.JSONRecordExtractor; +import org.apache.pinot.spi.data.readers.GenericRow; +import org.apache.pinot.spi.data.readers.RecordExtractor; +import org.apache.pinot.spi.plugin.PluginManager; +import org.apache.pinot.spi.stream.StreamMessageDecoder; +import org.apache.pinot.spi.utils.JsonUtils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import static com.google.common.base.Preconditions.checkState; + + +/** + * Decodes avro messages with confluent schema registry. + * First byte is MAGIC = 0, second 4 bytes are the schema id, the remainder is the value. + * NOTE: Do not use schema in the implementation, as schema will be removed from the params + */ +public class KafkaConfluentSchemaRegistryJsonMessageDecoder implements StreamMessageDecoder<byte[]> { + private static final Logger LOGGER = LoggerFactory.getLogger(KafkaConfluentSchemaRegistryJsonMessageDecoder.class); + private static final String SCHEMA_REGISTRY_REST_URL = "schema.registry.rest.url"; + private static final String SCHEMA_REGISTRY_OPTS_PREFIX = "schema.registry."; + public static final String CACHED_SCHEMA_MAP_CAPACITY = "cached.schema.map.capacity"; + public static final String DEFAULT_CACHED_SCHEMA_MAP_CAPACITY = "1000"; + private KafkaJsonSchemaDeserializer _deserializer; + private RecordExtractor<Map<String, Object>> _jsonRecordExtractor; + private String _topicName; + + public RestService createRestService(String schemaRegistryUrl, Map<String, String> configs) { + RestService restService = new RestService(schemaRegistryUrl); + + ConfigDef configDef = new ConfigDef(); + SslConfigs.addClientSslSupport(configDef); + Map<String, ConfigDef.ConfigKey> configKeyMap = configDef.configKeys(); + Map<String, Object> sslConfigs = new HashMap<>(); + for (String key : configs.keySet()) { + if (!key.equals(SCHEMA_REGISTRY_REST_URL) && key.startsWith(SCHEMA_REGISTRY_OPTS_PREFIX)) { + String value = configs.get(key); + String schemaRegistryOptKey = key.substring(SCHEMA_REGISTRY_OPTS_PREFIX.length()); + + if (configKeyMap.containsKey(schemaRegistryOptKey)) { + if (configKeyMap.get(schemaRegistryOptKey).type == ConfigDef.Type.PASSWORD) { + sslConfigs.put(schemaRegistryOptKey, new Password(value)); + } else { + sslConfigs.put(schemaRegistryOptKey, value); + } + } + } + } + + if (!sslConfigs.isEmpty()) { + DefaultSslEngineFactory sslFactory = new DefaultSslEngineFactory(); + sslFactory.configure(sslConfigs); + restService.setSslSocketFactory(sslFactory.sslContext().getSocketFactory()); + } + return restService; + } + + @Override + public void init(Map<String, String> props, Set<String> fieldsToRead, String topicName) + throws Exception { + checkState(props.containsKey(SCHEMA_REGISTRY_REST_URL), "Missing required property '%s'", SCHEMA_REGISTRY_REST_URL); + String schemaRegistryUrl = props.get(SCHEMA_REGISTRY_REST_URL); + JsonSchemaProvider jsonSchemaProvider = new JsonSchemaProvider(); + int identityMapCapacity = Integer.parseInt( + props.getOrDefault(CACHED_SCHEMA_MAP_CAPACITY, DEFAULT_CACHED_SCHEMA_MAP_CAPACITY)); + SchemaRegistryClient schemaRegistryClient = + new CachedSchemaRegistryClient(createRestService(schemaRegistryUrl, props), identityMapCapacity, + Collections.singletonList(jsonSchemaProvider), props, null); + + _deserializer = new KafkaJsonSchemaDeserializer(schemaRegistryClient); + Preconditions.checkNotNull(topicName, "Topic must be provided"); + _topicName = topicName; + _jsonRecordExtractor = PluginManager.get().createInstance(JSONRecordExtractor.class.getName()); + _jsonRecordExtractor.init(fieldsToRead, null); + } + + @Override + public GenericRow decode(byte[] payload, GenericRow destination) { + try { + JsonNode jsonRecord = (JsonNode) _deserializer.deserialize(_topicName, payload); + Map<String, Object> from = JsonUtils.jsonNodeToMap(jsonRecord); + return _jsonRecordExtractor.extract(from, destination); + } catch (RuntimeException e) { + ignoreOrRethrowException(e); + return null; + } catch (Exception e) { + LOGGER.error("Caught exception while decoding row, discarding row. Payload is {}", new String(payload), e); + return null; + } Review Comment: Fixed in the new commit, but I had to add an IOException handle due to the jsonNodeToMap function. ########## pinot-plugins/pinot-input-format/pinot-confluent-json/src/main/java/org/apache/pinot/plugin/inputformat/json/confluent/KafkaConfluentSchemaRegistryJsonMessageDecoder.java: ########## @@ -0,0 +1,153 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.plugin.inputformat.json.confluent; + +import com.fasterxml.jackson.databind.JsonNode; +import com.google.common.base.Preconditions; +import io.confluent.kafka.schemaregistry.client.CachedSchemaRegistryClient; +import io.confluent.kafka.schemaregistry.client.SchemaRegistryClient; +import io.confluent.kafka.schemaregistry.client.rest.RestService; +import io.confluent.kafka.schemaregistry.json.JsonSchemaProvider; +import io.confluent.kafka.serializers.json.KafkaJsonSchemaDeserializer; +import java.util.Arrays; +import java.util.Collections; +import java.util.HashMap; +import java.util.Map; +import java.util.Set; +import org.apache.kafka.common.config.ConfigDef; +import org.apache.kafka.common.config.SslConfigs; +import org.apache.kafka.common.config.types.Password; +import org.apache.kafka.common.errors.SerializationException; +import org.apache.kafka.common.security.ssl.DefaultSslEngineFactory; +import org.apache.pinot.plugin.inputformat.json.JSONRecordExtractor; +import org.apache.pinot.spi.data.readers.GenericRow; +import org.apache.pinot.spi.data.readers.RecordExtractor; +import org.apache.pinot.spi.plugin.PluginManager; +import org.apache.pinot.spi.stream.StreamMessageDecoder; +import org.apache.pinot.spi.utils.JsonUtils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import static com.google.common.base.Preconditions.checkState; + + +/** + * Decodes avro messages with confluent schema registry. + * First byte is MAGIC = 0, second 4 bytes are the schema id, the remainder is the value. + * NOTE: Do not use schema in the implementation, as schema will be removed from the params + */ +public class KafkaConfluentSchemaRegistryJsonMessageDecoder implements StreamMessageDecoder<byte[]> { + private static final Logger LOGGER = LoggerFactory.getLogger(KafkaConfluentSchemaRegistryJsonMessageDecoder.class); + private static final String SCHEMA_REGISTRY_REST_URL = "schema.registry.rest.url"; + private static final String SCHEMA_REGISTRY_OPTS_PREFIX = "schema.registry."; + public static final String CACHED_SCHEMA_MAP_CAPACITY = "cached.schema.map.capacity"; + public static final String DEFAULT_CACHED_SCHEMA_MAP_CAPACITY = "1000"; + private KafkaJsonSchemaDeserializer _deserializer; + private RecordExtractor<Map<String, Object>> _jsonRecordExtractor; + private String _topicName; + + public RestService createRestService(String schemaRegistryUrl, Map<String, String> configs) { + RestService restService = new RestService(schemaRegistryUrl); + + ConfigDef configDef = new ConfigDef(); + SslConfigs.addClientSslSupport(configDef); + Map<String, ConfigDef.ConfigKey> configKeyMap = configDef.configKeys(); + Map<String, Object> sslConfigs = new HashMap<>(); + for (String key : configs.keySet()) { + if (!key.equals(SCHEMA_REGISTRY_REST_URL) && key.startsWith(SCHEMA_REGISTRY_OPTS_PREFIX)) { + String value = configs.get(key); + String schemaRegistryOptKey = key.substring(SCHEMA_REGISTRY_OPTS_PREFIX.length()); + + if (configKeyMap.containsKey(schemaRegistryOptKey)) { + if (configKeyMap.get(schemaRegistryOptKey).type == ConfigDef.Type.PASSWORD) { + sslConfigs.put(schemaRegistryOptKey, new Password(value)); + } else { + sslConfigs.put(schemaRegistryOptKey, value); + } + } + } + } + + if (!sslConfigs.isEmpty()) { + DefaultSslEngineFactory sslFactory = new DefaultSslEngineFactory(); + sslFactory.configure(sslConfigs); + restService.setSslSocketFactory(sslFactory.sslContext().getSocketFactory()); + } + return restService; + } + + @Override + public void init(Map<String, String> props, Set<String> fieldsToRead, String topicName) + throws Exception { + checkState(props.containsKey(SCHEMA_REGISTRY_REST_URL), "Missing required property '%s'", SCHEMA_REGISTRY_REST_URL); + String schemaRegistryUrl = props.get(SCHEMA_REGISTRY_REST_URL); + JsonSchemaProvider jsonSchemaProvider = new JsonSchemaProvider(); + int identityMapCapacity = Integer.parseInt( + props.getOrDefault(CACHED_SCHEMA_MAP_CAPACITY, DEFAULT_CACHED_SCHEMA_MAP_CAPACITY)); + SchemaRegistryClient schemaRegistryClient = + new CachedSchemaRegistryClient(createRestService(schemaRegistryUrl, props), identityMapCapacity, + Collections.singletonList(jsonSchemaProvider), props, null); + + _deserializer = new KafkaJsonSchemaDeserializer(schemaRegistryClient); + Preconditions.checkNotNull(topicName, "Topic must be provided"); + _topicName = topicName; + _jsonRecordExtractor = PluginManager.get().createInstance(JSONRecordExtractor.class.getName()); + _jsonRecordExtractor.init(fieldsToRead, null); + } + + @Override + public GenericRow decode(byte[] payload, GenericRow destination) { + try { + JsonNode jsonRecord = (JsonNode) _deserializer.deserialize(_topicName, payload); + Map<String, Object> from = JsonUtils.jsonNodeToMap(jsonRecord); + return _jsonRecordExtractor.extract(from, destination); + } catch (RuntimeException e) { + ignoreOrRethrowException(e); + return null; + } catch (Exception e) { + LOGGER.error("Caught exception while decoding row, discarding row. Payload is {}", new String(payload), e); + return null; + } Review Comment: It was fixed in the new commit, but I had to add an IOException handle due to the jsonNodeToMap function. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
