chenboat commented on code in PR #15234:
URL: https://github.com/apache/pinot/pull/15234#discussion_r2002251422
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -1210,6 +1222,19 @@ boolean commitSegment(String controllerVipUrl)
return true;
}
+ @VisibleForTesting
+ void notifySegmentCannotBuild() {
Review Comment:
rename the method to notifySegmentBuildFailure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
