himanish-star commented on code in PR #15256: URL: https://github.com/apache/pinot/pull/15256#discussion_r2001310006
########## pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerOptions.ts: ########## @@ -0,0 +1,150 @@ +export type RebalanceServerOption = { + name: string; + label: string; + type: "BOOL" | "INTEGER" | "SELECT"; + description: string; + defaultValue: string | boolean | number; + isAdvancedConfig: boolean; + isStatsGatheringConfig: boolean; + hasBreakingChange: boolean; + allowedValues?: string[]; + toolTip?: string; +} + +export const rebalanceServerOptions: RebalanceServerOption[] = [ + { + "name": "dryRun", + "defaultValue": false, + "label": "Dry Run", + "type": "BOOL", + "description": "If enabled, rebalance will not run but expected changes that will occur will be returned", + "isAdvancedConfig": false, + "isStatsGatheringConfig": true, + "hasBreakingChange": false + }, + { + "name": "preChecks", + "defaultValue": false, + "type": "BOOL", + "label": "Pre-Checks", + "description": "If enabled, will perform some pre-checks to ensure rebalance is safe, must enable dryRun to enable this", + "isAdvancedConfig": false, + "isStatsGatheringConfig": true, + "hasBreakingChange": false + }, + { + "name": "reassignInstances", + "defaultValue": true, + "type": "BOOL", + "label": "Reassign Instances", + "description": "Reassigns the instances of the table prior to segment assignment if explicit assignment is enabled, no-op otherwise", + "isAdvancedConfig": false, + "isStatsGatheringConfig": false, + "hasBreakingChange": false + }, + { + "name": "includeConsuming", + "defaultValue": true, + "type": "BOOL", + "label": "Include Consuming", + "description": "CONSUMING segments are rebalanced only if this is set to true, mandatory for upsert/dedup tables, ignored for OFFLINE tables", + "isAdvancedConfig": false, + "isStatsGatheringConfig": false, + "hasBreakingChange": false + }, + { + "name": "minimizeDataMovement", + "defaultValue": "ENABLE", + "type": "SELECT", + "allowedValues": ["ENABLE", "DISABLE", "DEFAULT"], + "label": "Minimize Data Movement", + "description": "Minimize data movement if set to ENABLE, disable if set to DISABLE, and use minimizeDataMovement value in TableConfig if DEFAULT. Minimize data movement only applies for explicit assignment and is a no-op otherwise", + "isAdvancedConfig": false, + "isStatsGatheringConfig": false, + "hasBreakingChange": true, + "toolTip": "Disabling minimizeDataMovement can cause a large amount of data movement" + }, + { + "name": "bootstrap", + "defaultValue": false, + "type": "BOOL", + "label": "Bootstrap", + "description": "Regardless of minimum segment movement, reassign all segments in a round-robin fashion as if adding new segments to an empty table", + "isAdvancedConfig": true, + "isStatsGatheringConfig": false, + "hasBreakingChange": true, + "toolTip": "Enabling bootstrap can cause a large amount of data movement" + }, + { + "name": "downtime", + "defaultValue": false, + "type": "BOOL", + "label": "Downtime", + "description": "Whether to allow downtime for rebalance or not, must be set to true if replication = 1", + "isAdvancedConfig": false, + "isStatsGatheringConfig": false, + "hasBreakingChange": true, + "toolTip": "Enabling can cause downtime even if replication > 1" Review Comment: Sure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org