itschrispeck commented on code in PR #15139:
URL: https://github.com/apache/pinot/pull/15139#discussion_r2002314552
##########
pinot-core/src/main/java/org/apache/pinot/core/common/DataFetcher.java:
##########
@@ -594,4 +594,17 @@ public void close()
}
}
}
+
+ /**
+ * Close the DataFetcher and release all resources (specifically, the
ForwardIndexReaderContext off-heap buffers).
+ */
+ public void close() {
+ try {
+ for (ColumnValueReader columnValueReader :
_columnValueReaderMap.values()) {
+ columnValueReader.close();
+ }
+ } catch (IOException e) {
+ // do nothing
Review Comment:
Updated to `CleanerUtil.closeQuietly()` and ForwardIndexReaderContext to no
longer throw an exception on close as none of the implementations do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
