KKcorps commented on code in PR #8467:
URL: https://github.com/apache/pinot/pull/8467#discussion_r855814316
##
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/BrokerCacheUpdaterPeriodic.java:
##
@@ -0,0 +1,88 @@
+/**
+ * Licensed to the Apache Software Foun
KKcorps commented on code in PR #8467:
URL: https://github.com/apache/pinot/pull/8467#discussion_r855812972
##
pinot-clients/pinot-java-client/src/test/java/org/apache/pinot/client/ControllerBrokerSelectorTest.java:
##
@@ -0,0 +1,36 @@
+/**
+ * Licensed to the Apache Software Fo
saurabhd336 commented on code in PR #8514:
URL: https://github.com/apache/pinot/pull/8514#discussion_r855783985
##
pinot-controller/src/test/java/org/apache/pinot/controller/api/PinotTableRestletResourceTest.java:
##
@@ -536,9 +552,9 @@ public void testValidate()
.b
saurabhd336 commented on code in PR #8514:
URL: https://github.com/apache/pinot/pull/8514#discussion_r855765360
##
pinot-spi/src/test/java/org/apache/pinot/spi/utils/TestClass.java:
##
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mo
saurabhd336 commented on code in PR #8514:
URL: https://github.com/apache/pinot/pull/8514#discussion_r855765496
##
pinot-spi/src/test/java/org/apache/pinot/spi/utils/TestClass.java:
##
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mo
saurabhd336 commented on code in PR #8514:
URL: https://github.com/apache/pinot/pull/8514#discussion_r855764664
##
pinot-spi/src/main/java/org/apache/pinot/spi/utils/JsonUtils.java:
##
@@ -71,12 +88,53 @@ private JsonUtils() {
public static final ObjectReader DEFAULT_READER =
saurabhd336 commented on code in PR #8514:
URL: https://github.com/apache/pinot/pull/8514#discussion_r855764190
##
pinot-spi/src/main/java/org/apache/pinot/spi/utils/JsonUtils.java:
##
@@ -71,12 +88,53 @@ private JsonUtils() {
public static final ObjectReader DEFAULT_READER =
saurabhd336 commented on code in PR #8514:
URL: https://github.com/apache/pinot/pull/8514#discussion_r855764190
##
pinot-spi/src/main/java/org/apache/pinot/spi/utils/JsonUtils.java:
##
@@ -71,12 +88,53 @@ private JsonUtils() {
public static final ObjectReader DEFAULT_READER =
saurabhd336 commented on code in PR #8514:
URL: https://github.com/apache/pinot/pull/8514#discussion_r855761860
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java:
##
@@ -492,18 +498,22 @@ public SuccessResponse updateTable
saurabhd336 commented on code in PR #8514:
URL: https://github.com/apache/pinot/pull/8514#discussion_r855760869
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/ConfigSuccessResponse.java:
##
@@ -0,0 +1,34 @@
+/**
+ * Licensed to the Apache Software Fo
walterddr commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855750062
##
pinot-query-planner/src/main/java/org/apache/pinot/query/rules/PinotExchangeNodeInsertRule.java:
##
@@ -57,12 +63,26 @@ public boolean matches(RelOptRuleCall call) {
siddharthteotia commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855693573
##
pinot-query-planner/src/main/java/org/apache/pinot/query/rules/PinotExchangeNodeInsertRule.java:
##
@@ -57,12 +63,26 @@ public boolean matches(RelOptRuleCall ca
npawar commented on code in PR #8514:
URL: https://github.com/apache/pinot/pull/8514#discussion_r855685792
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java:
##
@@ -492,18 +498,22 @@ public SuccessResponse updateTableConfi
Jackie-Jiang commented on code in PR #8483:
URL: https://github.com/apache/pinot/pull/8483#discussion_r855564628
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceReplicaGroupPartitionSelector.java:
##
@@ -37,13 +46,15 @@
publi
walterddr commented on issue #8537:
URL: https://github.com/apache/pinot/issues/8537#issuecomment-1105840574
this seems to be still recurring:
https://github.com/apache/pinot/runs/6120269495?check_suite_focus=true.
if I understood correctly github action always merge master before ru
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new f200ec5156 Added multi column partitioning for of
Jackie-Jiang merged PR #8255:
URL: https://github.com/apache/pinot/pull/8255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.a
Jackie-Jiang commented on issue #8579:
URL: https://github.com/apache/pinot/issues/8579#issuecomment-1105827444
Did you recently refreshed this segment (push a new segment with same name
but different content)? The only explanation to this behavior is that the
segment refresh message is som
walterddr opened a new pull request, #8580:
URL: https://github.com/apache/pinot/pull/8580
testing POC for FunctionDefinition
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
deemoliu commented on issue #8579:
URL: https://github.com/apache/pinot/issues/8579#issuecomment-1105818586
cc: @yupeng9 @chenboat @Jackie-Jiang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
deemoliu opened a new issue, #8579:
URL: https://github.com/apache/pinot/issues/8579
We lose some data after migrating table to another tenant and rebalancing
with downtime (no server restart). Is server restart a required step after
migrating table to another tenant?
We did the foll
KKcorps opened a new pull request, #8578:
URL: https://github.com/apache/pinot/pull/8578
Add supports to specifiy the following configs as part of JDBC connection
properties
```java
public static final String KEYSTORE_TYPE = "keystore.type";
public static final String KEYST
PrachiKhobragade commented on code in PR #8572:
URL: https://github.com/apache/pinot/pull/8572#discussion_r855616042
##
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/ClusterChangeMediator.java:
##
@@ -210,21 +206,21 @@ public void onLiveInstanceChange(List
liv
dongxiaoman commented on code in PR #8567:
URL: https://github.com/apache/pinot/pull/8567#discussion_r855612260
##
pinot-tools/src/main/java/org/apache/pinot/tools/streams/RsvpSourceGenerator.java:
##
@@ -0,0 +1,98 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) und
walterddr commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855611429
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/nodes/RexExpression.java:
##
@@ -0,0 +1,157 @@
+/**
+ * Licensed to the Apache Software Foundation (A
dongxiaoman commented on code in PR #8567:
URL: https://github.com/apache/pinot/pull/8567#discussion_r855611494
##
pinot-tools/src/main/java/org/apache/pinot/tools/streams/MeetupRsvpStream.java:
##
@@ -60,94 +41,40 @@ public MeetupRsvpStream()
public MeetupRsvpStream(boolea
walterddr commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855611429
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/nodes/RexExpression.java:
##
@@ -0,0 +1,157 @@
+/**
+ * Licensed to the Apache Software Foundation (A
dongxiaoman commented on code in PR #8567:
URL: https://github.com/apache/pinot/pull/8567#discussion_r855611007
##
pinot-tools/src/main/java/org/apache/pinot/tools/streams/MeetupRsvpJsonStream.java:
##
@@ -1,53 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) un
walterddr commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855482922
##
pinot-query-planner/src/test/java/org/apache/pinot/query/planner/nodes/SerDeUtilsTest.java:
##
@@ -0,0 +1,80 @@
+/**
+ * Licensed to the Apache Software Foundation (A
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from a954d85d29 Adding missing prometheus metrics to controller.yml (#8576)
add d15847828a Package kafka 0.9 shaded ja
xiangfu0 merged PR #8569:
URL: https://github.com/apache/pinot/pull/8569
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apach
This is an automated email from the ASF dual-hosted git repository.
richardstartin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new a954d85d29 Adding missing prometheus metr
richardstartin merged PR #8576:
URL: https://github.com/apache/pinot/pull/8576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
KKcorps opened a new issue, #8577:
URL: https://github.com/apache/pinot/issues/8577
Currently Java client supports HTTPS but JDBC clients doesn't expose these
configs for end user. You can configure the protocol using the `scheme`
property but no configs exist to configure TLS props.
--
codecov-commenter commented on PR #8575:
URL: https://github.com/apache/pinot/pull/8575#issuecomment-1105700483
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8575?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar
timsants opened a new pull request, #8576:
URL: https://github.com/apache/pinot/pull/8576
Initially added new metrics to the pinot.yml file
[PR](https://github.com/apache/pinot/pull/8358) which is now deprecated. PR
should be tagged with `observability`.
--
This is an automated message f
Jackie-Jiang opened a new pull request, #8575:
URL: https://github.com/apache/pinot/pull/8575
- Merge ControllerSegmentUrlBuilder into ControllerRequestURLBuilder
- Directly use `Charset` when encoding/decoding for performance and not
unnecessarily throwing exception
- Fix some missing
walterddr commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855479255
##
pinot-query-planner/src/main/java/org/apache/pinot/query/rules/PinotExchangeNodeInsertRule.java:
##
@@ -57,12 +60,21 @@ public boolean matches(RelOptRuleCall call) {
Jackie-Jiang commented on code in PR #8514:
URL: https://github.com/apache/pinot/pull/8514#discussion_r855453394
##
pinot-spi/src/test/java/org/apache/pinot/spi/utils/TestClass.java:
##
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or m
siddharthteotia commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855472401
##
pinot-query-planner/src/main/java/org/apache/pinot/query/parser/CalciteRexExpressionParser.java:
##
@@ -0,0 +1,217 @@
+/**
+ * Licensed to the Apache Software F
siddharthteotia commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855469081
##
pinot-query-planner/src/test/java/org/apache/pinot/query/QueryEnvironmentTest.java:
##
@@ -96,28 +85,19 @@ public void testQueryToStages()
}
@Test
- pu
siddharthteotia commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855460689
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MailboxSendOperator.java:
##
@@ -142,6 +152,13 @@ protected DataTableBlock getNextBloc
siddharthteotia commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855451443
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/nodes/RexExpression.java:
##
@@ -0,0 +1,157 @@
+/**
+ * Licensed to the Apache Software Foundat
siddharthteotia commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855446659
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/nodes/RexExpression.java:
##
@@ -0,0 +1,157 @@
+/**
+ * Licensed to the Apache Software Foundat
siddharthteotia commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855443180
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/nodes/RexExpression.java:
##
@@ -0,0 +1,157 @@
+/**
+ * Licensed to the Apache Software Foundat
Jackie-Jiang commented on code in PR #8498:
URL: https://github.com/apache/pinot/pull/8498#discussion_r855430611
##
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/H3InclusionIndexFilterOperator.java:
##
@@ -0,0 +1,160 @@
+/**
+ * Licensed to the Apache Software F
siddharthteotia commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855433820
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/nodes/RexExpression.java:
##
@@ -0,0 +1,157 @@
+/**
+ * Licensed to the Apache Software Foundat
This is an automated email from the ASF dual-hosted git repository.
snlee pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 4f788b2995 Fix the deadlock in ClusterChangeMediator (#8572)
add 2fba4b0cb7 Add query option to use more replica gr
snleee closed issue #8217: Add a query option to use more replica groups
URL: https://github.com/apache/pinot/issues/8217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
snleee merged PR #8550:
URL: https://github.com/apache/pinot/pull/8550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.
saurabhd336 commented on code in PR #8563:
URL: https://github.com/apache/pinot/pull/8563#discussion_r855425462
##
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ExpressionFunctions.java:
##
@@ -0,0 +1,46 @@
+/**
+ * Licensed to the Apache Software Foundation
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 4f788b2995 Fix the deadlock in ClusterChangeMedia
Jackie-Jiang merged PR #8572:
URL: https://github.com/apache/pinot/pull/8572
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.a
Jackie-Jiang commented on code in PR #8572:
URL: https://github.com/apache/pinot/pull/8572#discussion_r855416302
##
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/ClusterChangeMediator.java:
##
@@ -210,21 +206,21 @@ public void onLiveInstanceChange(List
liveIns
Jackie-Jiang commented on PR #8310:
URL: https://github.com/apache/pinot/pull/8310#issuecomment-1105486851
@mcvsubbu It should have the same behavior as setting `allowNullTimeValue`
before (always enabled). The only difference is that when users explicitly put
the default value, we will fil
siddharthteotia commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855405640
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/executor/WorkerQueryExecutor.java:
##
@@ -98,22 +100,27 @@ public void runJob() {
private Ba
siddharthteotia commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855395674
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/StagePlanner.java:
##
@@ -95,12 +97,15 @@ private StageNode walkRelPlan(RelNode node, int
curr
siddharthteotia commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855377344
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/RelToStageConverter.java:
##
@@ -24,16 +24,18 @@
import java.util.stream.Collectors;
import o
siddharthteotia commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855391781
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/nodes/RexExpression.java:
##
@@ -0,0 +1,157 @@
+/**
+ * Licensed to the Apache Software Foundat
siddharthteotia commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855388522
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/nodes/MailboxSendNode.java:
##
@@ -18,21 +18,35 @@
*/
package org.apache.pinot.query.planner
siddharthteotia commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855387954
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/nodes/ProjectNode.java:
##
@@ -0,0 +1,47 @@
+/**
+ * Licensed to the Apache Software Foundation
siddharthteotia commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855380265
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/nodes/AbstractStageNode.java:
##
@@ -20,18 +20,25 @@
Review Comment:
(nit) shall we renam
mcvsubbu commented on PR #8310:
URL: https://github.com/apache/pinot/pull/8310#issuecomment-1105449917
@Jackie-Jiang this should be labelled backward-incompat if anyone had the
setting for `allowNullTimeValue` ?
--
This is an automated message from the Apache Git Service.
To respond to th
siddharthteotia commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855381193
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/nodes/AbstractStageNode.java:
##
@@ -20,18 +20,25 @@
import java.util.ArrayList;
import jav
siddharthteotia commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855387615
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/nodes/MailboxSendNode.java:
##
@@ -18,21 +18,35 @@
*/
package org.apache.pinot.query.planner
siddharthteotia commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855386729
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/nodes/FilterNode.java:
##
@@ -18,21 +18,25 @@
*/
package org.apache.pinot.query.planner.node
walterddr commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855386029
##
pinot-common/src/main/proto/plan.proto:
##
@@ -76,8 +76,9 @@ message LiteralField {
bool boolField = 1;
int32 intField = 2;
int64 longField = 3;
-d
walterddr commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855385678
##
pinot-query-planner/src/main/java/org/apache/pinot/query/parser/CalciteExpressionParser.java:
##
@@ -46,10 +45,10 @@
/**
- * Calcite parser to convert SQL expres
walterddr commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855385537
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/RelToStageConverter.java:
##
@@ -24,16 +24,18 @@
import java.util.stream.Collectors;
import org.apa
walterddr commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855385322
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/StagePlanner.java:
##
@@ -95,12 +97,15 @@ private StageNode walkRelPlan(RelNode node, int
currentSta
walterddr commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855384407
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/StagePlanner.java:
##
@@ -67,11 +68,12 @@ public QueryPlan makePlan(RelNode relRoot) {
StageNode
siddharthteotia commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855374289
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/StagePlanner.java:
##
@@ -67,11 +68,12 @@ public QueryPlan makePlan(RelNode relRoot) {
Sta
siddharthteotia commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855377495
##
pinot-query-planner/src/main/java/org/apache/pinot/query/parser/CalciteExpressionParser.java:
##
@@ -46,10 +45,10 @@
/**
- * Calcite parser to convert SQL
siddharthteotia commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855382139
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/nodes/MailboxSendNode.java:
##
@@ -18,21 +18,35 @@
*/
package org.apache.pinot.query.planner
siddharthteotia commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855377875
##
pinot-common/src/main/proto/plan.proto:
##
@@ -76,8 +76,9 @@ message LiteralField {
bool boolField = 1;
int32 intField = 2;
int64 longField = 3;
siddharthteotia commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855374289
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/StagePlanner.java:
##
@@ -67,11 +68,12 @@ public QueryPlan makePlan(RelNode relRoot) {
Sta
siddharthteotia commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855374289
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/StagePlanner.java:
##
@@ -67,11 +68,12 @@ public QueryPlan makePlan(RelNode relRoot) {
Sta
noon-stripe closed pull request #8462: Generalized Ingestion Pre-Aggregation
URL: https://github.com/apache/pinot/pull/8462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
codecov-commenter commented on PR #8574:
URL: https://github.com/apache/pinot/pull/8574#issuecomment-1105183701
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8574?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar
saurabhd336 opened a new pull request, #8574:
URL: https://github.com/apache/pinot/pull/8574
Add /health API to minion to be able to monitor minion health
GH issue: https://github.com/apache/pinot/issues/8515
--
This is an automated message from the Apache Git Service.
To respond to the
saurabhd336 commented on code in PR #8467:
URL: https://github.com/apache/pinot/pull/8467#discussion_r855031536
##
pinot-clients/pinot-java-client/src/test/java/org/apache/pinot/client/ControllerBrokerSelectorTest.java:
##
@@ -0,0 +1,36 @@
+/**
+ * Licensed to the Apache Softwar
saurabhd336 commented on code in PR #8467:
URL: https://github.com/apache/pinot/pull/8467#discussion_r855014253
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##
@@ -3374,6 +3376,40 @@ public TableStats getTableStats(Stri
saurabhd336 commented on code in PR #8467:
URL: https://github.com/apache/pinot/pull/8467#discussion_r855012799
##
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/BrokerCacheUpdaterPeriodic.java:
##
@@ -0,0 +1,88 @@
+/**
+ * Licensed to the Apache Software
saurabhd336 commented on code in PR #8467:
URL: https://github.com/apache/pinot/pull/8467#discussion_r855012320
##
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/ConnectionFactory.java:
##
@@ -43,6 +43,29 @@ public static Connection fromZookeeper(String zk
saurabhd336 commented on code in PR #8467:
URL: https://github.com/apache/pinot/pull/8467#discussion_r855007215
##
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/BrokerCacheUpdaterPeriodic.java:
##
@@ -0,0 +1,88 @@
+/**
+ * Licensed to the Apache Software
saurabhd336 commented on code in PR #8467:
URL: https://github.com/apache/pinot/pull/8467#discussion_r855006775
##
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/BrokerCache.java:
##
@@ -0,0 +1,165 @@
+/**
+ * Licensed to the Apache Software Foundation (AS
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new fe1423162e Move controllerUrlUtils to SPI (#8573
xiangfu0 merged PR #8573:
URL: https://github.com/apache/pinot/pull/8573
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apach
xiangfu0 commented on PR #8573:
URL: https://github.com/apache/pinot/pull/8573#issuecomment-1104877656
Thanks @saurabhd336
I also need this in https://github.com/apache/pinot/pull/8557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
richardstartin commented on code in PR #8563:
URL: https://github.com/apache/pinot/pull/8563#discussion_r854915142
##
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ExpressionFunctions.java:
##
@@ -0,0 +1,46 @@
+/**
+ * Licensed to the Apache Software Foundat
KKcorps commented on PR #8563:
URL: https://github.com/apache/pinot/pull/8563#issuecomment-1104854552
I think there should be support for operators as well in filters such as
`==`, `>=` etc. rather than only relying on functional equivalents. However,
that might increase the scope of this P
richardstartin commented on code in PR #8563:
URL: https://github.com/apache/pinot/pull/8563#discussion_r854910227
##
pinot-common/src/main/java/org/apache/pinot/common/function/FunctionRegistry.java:
##
@@ -122,7 +141,12 @@ public static boolean containsFunction(String
functio
richardstartin commented on code in PR #8563:
URL: https://github.com/apache/pinot/pull/8563#discussion_r854908612
##
pinot-common/src/main/java/org/apache/pinot/common/function/FunctionInvoker.java:
##
@@ -124,7 +140,16 @@ public Class getResultClass() {
*/
public Object
KKcorps commented on code in PR #8563:
URL: https://github.com/apache/pinot/pull/8563#discussion_r854906899
##
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ArithmeticFunctions.java:
##
@@ -153,4 +152,19 @@ public static double truncate(double a, int scale)
KKcorps commented on code in PR #8563:
URL: https://github.com/apache/pinot/pull/8563#discussion_r854904609
##
pinot-common/src/main/java/org/apache/pinot/common/function/FunctionInvoker.java:
##
@@ -87,27 +88,42 @@ public PinotDataType[] getParameterTypes() {
* conversion i
richardstartin commented on code in PR #8563:
URL: https://github.com/apache/pinot/pull/8563#discussion_r854902219
##
pinot-common/src/main/java/org/apache/pinot/common/function/FunctionInvoker.java:
##
@@ -87,27 +88,42 @@ public PinotDataType[] getParameterTypes() {
* conve
saurabhd336 commented on PR #8573:
URL: https://github.com/apache/pinot/pull/8573#issuecomment-1104845236
Done @richardstartin. @xiangfu0 had some other dependencies on this PR. I
wanted to be able to use the util class in pinot-clients for
https://github.com/apache/pinot/pull/8467
--
richardstartin commented on PR #8573:
URL: https://github.com/apache/pinot/pull/8573#issuecomment-1104836573
@saurabhd336 can you explain the motivation in the PR description please
(you can delete the template).
--
This is an automated message from the Apache Git Service.
To respond to t
KKcorps commented on code in PR #8467:
URL: https://github.com/apache/pinot/pull/8467#discussion_r854852620
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##
@@ -3374,6 +3376,40 @@ public TableStats getTableStats(String
xiangfu0 closed pull request #8573: Move ControllerRequestURLBuilder to SPI
URL: https://github.com/apache/pinot/pull/8573
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
100 matches
Mail list logo
