richardstartin commented on code in PR #8563:
URL: https://github.com/apache/pinot/pull/8563#discussion_r854910227
##########
pinot-common/src/main/java/org/apache/pinot/common/function/FunctionRegistry.java:
##########
@@ -122,7 +141,12 @@ public static boolean containsFunction(String
functionName) {
@Nullable
public static FunctionInfo getFunctionInfo(String functionName, int
numParameters) {
Map<Integer, FunctionInfo> functionInfoMap =
FUNCTION_INFO_MAP.get(canonicalize(functionName));
- return functionInfoMap != null ? functionInfoMap.get(numParameters) : null;
+
+ if (functionInfoMap != null && functionInfoMap.containsKey(numParameters))
{
+ return functionInfoMap.get(numParameters);
+ } else {
+ return VARARGS_FUNCTION_INFO_MAP.getOrDefault(functionName, null);
Review Comment:
`Map#get` does the same thing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
