richardstartin commented on code in PR #8563: URL: https://github.com/apache/pinot/pull/8563#discussion_r854915142
########## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ExpressionFunctions.java: ########## @@ -0,0 +1,46 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.common.function.scalar; + +import org.apache.pinot.spi.annotations.ScalarFunction; + +public class ExpressionFunctions { + private ExpressionFunctions() { + } + + @ScalarFunction(vargsFunction = true) + public static boolean and(Boolean... args) { + for (Boolean arg : args) { + if (!arg) { + return false; + } + } + return true; + } Review Comment: This function is to support logical conjugation of predicates, but is it the right approach? This requires all expressions to be evaluated before they are combined, and prevents early termination. Early termination is not just a performance concern, but one of flexibility and correctness - it should be possible to express predicates which aren't safe to evaluate if another predicate acts as a guard to prevent its evaluation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
