walterddr commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855750062
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/rules/PinotExchangeNodeInsertRule.java:
##########
@@ -57,12 +63,26 @@ public boolean matches(RelOptRuleCall call) {
@Override
public void onMatch(RelOptRuleCall call) {
+ // TODO: this only works for single equality JOIN. add generic condition
parser
Join join = call.rel(0);
RelNode leftInput = join.getInput(0);
RelNode rightInput = join.getInput(1);
- RelNode leftExchange = LogicalExchange.create(leftInput,
RelDistributions.SINGLETON);
- RelNode rightExchange = LogicalExchange.create(rightInput,
RelDistributions.BROADCAST_DISTRIBUTED);
+ RelNode leftExchange;
+ RelNode rightExchange;
+ List<RelHint> hints = join.getHints();
+ if (hints.contains(PinotRelationalHints.USE_HASH_JOIN)) {
Review Comment:
renamed. sorry for the confusion this should be `USE_HASH_DISTRIBUTE`. has
nothing to do with the join type
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/rules/PinotExchangeNodeInsertRule.java:
##########
@@ -57,12 +63,26 @@ public boolean matches(RelOptRuleCall call) {
@Override
public void onMatch(RelOptRuleCall call) {
+ // TODO: this only works for single equality JOIN. add generic condition
parser
Join join = call.rel(0);
RelNode leftInput = join.getInput(0);
RelNode rightInput = join.getInput(1);
- RelNode leftExchange = LogicalExchange.create(leftInput,
RelDistributions.SINGLETON);
- RelNode rightExchange = LogicalExchange.create(rightInput,
RelDistributions.BROADCAST_DISTRIBUTED);
+ RelNode leftExchange;
+ RelNode rightExchange;
+ List<RelHint> hints = join.getHints();
+ if (hints.contains(PinotRelationalHints.USE_HASH_JOIN)) {
Review Comment:
renamed. sorry for the confusion this should be `USE_HASH_DISTRIBUTE`. it is
not meant to hint the join algorithm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
