siddharthteotia commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855386729
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/nodes/FilterNode.java:
##########
@@ -18,21 +18,25 @@
*/
package org.apache.pinot.query.planner.nodes;
+import org.apache.calcite.rel.type.RelDataType;
+import org.apache.calcite.rex.RexNode;
+import org.apache.pinot.query.planner.nodes.serde.ProtoProperties;
-public class CalcNode extends AbstractStageNode {
- private String _expression;
+public class FilterNode extends AbstractStageNode {
+ @ProtoProperties
+ private RexExpression _condition;
- public CalcNode(int stageId) {
- super(stageId);
+ public FilterNode(int stageId) {
+ super(stageId, null);
Review Comment:
I think `rowType` should be known and non-null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
