siddharthteotia commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855382139
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/nodes/MailboxSendNode.java:
##########
@@ -18,21 +18,35 @@
*/
package org.apache.pinot.query.planner.nodes;
+import javax.annotation.Nullable;
import org.apache.calcite.rel.RelDistribution;
+import org.apache.calcite.rel.type.RelDataType;
+import org.apache.pinot.query.planner.nodes.serde.ProtoProperties;
+import org.apache.pinot.query.planner.partitioning.KeySelector;
public class MailboxSendNode extends AbstractStageNode {
+ @ProtoProperties
private int _receiverStageId;
+ @ProtoProperties
private RelDistribution.Type _exchangeType;
+ @ProtoProperties
+ private KeySelector<Object[], Object> _partitionKeySelector;
public MailboxSendNode(int stageId) {
- super(stageId);
+ super(stageId, null);
}
- public MailboxSendNode(int stageId, int receiverStageId,
RelDistribution.Type exchangeType) {
- super(stageId);
+ public MailboxSendNode(int stageId, RelDataType rowType, int
receiverStageId, RelDistribution.Type exchangeType) {
+ this(stageId, rowType, receiverStageId, exchangeType, null);
+ }
+
+ public MailboxSendNode(int stageId, RelDataType rowType, int
receiverStageId, RelDistribution.Type exchangeType,
+ @Nullable KeySelector<Object[], Object> partitionKeySelector) {
+ super(stageId, rowType);
_receiverStageId = receiverStageId;
_exchangeType = exchangeType;
+ _partitionKeySelector = partitionKeySelector;
Review Comment:
This should be non-null only if exchange type is hash based ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
