siddharthteotia commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855381193
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/nodes/AbstractStageNode.java:
##########
@@ -20,18 +20,25 @@
import java.util.ArrayList;
import java.util.List;
+import org.apache.calcite.rel.type.RelDataType;
import org.apache.pinot.common.proto.Plan;
+import org.apache.pinot.query.planner.nodes.serde.ProtoProperties;
import org.apache.pinot.query.planner.nodes.serde.ProtoSerializable;
import org.apache.pinot.query.planner.nodes.serde.ProtoSerializationUtils;
public abstract class AbstractStageNode implements StageNode,
ProtoSerializable {
+ @ProtoProperties
protected final int _stageId;
+ @ProtoProperties
protected final List<StageNode> _inputs;
+ @ProtoProperties
+ protected RelDataType _rowType;
- public AbstractStageNode(int stageId) {
+ public AbstractStageNode(int stageId, RelDataType rowType) {
_stageId = stageId;
+ _rowType = rowType;
Review Comment:
Assert for non-null ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
