siddharthteotia commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855377495
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/parser/CalciteExpressionParser.java:
##########
@@ -46,10 +45,10 @@
/**
- * Calcite parser to convert SQL expressions into {@link Expression}.
+ * This class provide API to parse a SQL string into Pinot query {@link
SqlNode}.
Review Comment:
I feel this class should ideally be deleted. It will get difficult to
maintain parity between this and existing CalciteSqlParser especially because
both work on SQL -> SqlNode -> PinotQuery
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
