npawar commented on code in PR #8514:
URL: https://github.com/apache/pinot/pull/8514#discussion_r855685792
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java:
##########
@@ -492,18 +498,22 @@ public SuccessResponse updateTableConfig(
@ApiOperation(value = "Validate table config for a table",
notes = "This API returns the table config that matches the one you get
from 'GET /tables/{tableName}'."
+ " This allows us to validate table config before apply.")
- public String checkTableConfig(
+ public ObjectNode checkTableConfig(
Review Comment:
should we take this opportunity to also wrap this into a
ConfigValidationResponse object?
##########
pinot-spi/src/test/java/org/apache/pinot/spi/utils/TestClass.java:
##########
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.spi.utils;
+
+import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
+
+
+@JsonIgnoreProperties(ignoreUnknown = true)
+public class TestClass {
Review Comment:
should this just be inside JsonUtilsTest? It's very non-generic to be by
itself
##########
pinot-controller/src/test/java/org/apache/pinot/controller/api/PinotTableRestletResourceTest.java:
##########
@@ -536,9 +552,9 @@ public void testValidate()
.build();
try {
- ControllerTestUtils
- .sendPostRequest(StringUtil.join("/",
ControllerTestUtils.getControllerBaseApiUrl(), "tables", "validate"),
- offlineTableConfig.toJsonString());
+ ControllerTestUtils.sendPostRequest(
Review Comment:
would be nice to have couple of tests in validate.
1. validation success, but unparseable props
2. validation failed
to make sure both these experiences are unaffected by this change
(optional) test case in add and update too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
