siddharthteotia commented on code in PR #8558: URL: https://github.com/apache/pinot/pull/8558#discussion_r855472401
########## pinot-query-planner/src/main/java/org/apache/pinot/query/parser/CalciteRexExpressionParser.java: ########## @@ -0,0 +1,217 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.query.parser; + +import com.google.common.base.Preconditions; +import java.util.ArrayList; +import java.util.Iterator; +import java.util.List; +import org.apache.calcite.rel.type.RelDataType; +import org.apache.calcite.sql.SqlKind; +import org.apache.pinot.common.request.Expression; +import org.apache.pinot.common.request.ExpressionType; +import org.apache.pinot.common.request.Function; +import org.apache.pinot.common.request.PinotQuery; +import org.apache.pinot.common.utils.request.RequestUtils; +import org.apache.pinot.query.planner.nodes.RexExpression; +import org.apache.pinot.segment.spi.AggregationFunctionType; +import org.apache.pinot.sql.parsers.SqlCompilationException; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +/** + * Calcite parser to convert SQL expressions into {@link Expression}. + * + * <p>This class is extracted from {@link org.apache.pinot.sql.parsers.CalciteSqlParser}. It contains the logic + * to parsed {@link org.apache.calcite.rex.RexNode}, in the format of {@link RexExpression} and convert them into + * Thrift {@link Expression} format. + */ +public class CalciteRexExpressionParser { Review Comment: Let's discuss this a bit. I am not sure why we need this (unless we are planning to use the RelDataType information coming from calcite row expression nodes) and how this will be plugged into the planning stage -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
