saurabhd336 commented on code in PR #8514:
URL: https://github.com/apache/pinot/pull/8514#discussion_r855761860
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java:
##########
@@ -492,18 +498,22 @@ public SuccessResponse updateTableConfig(
@ApiOperation(value = "Validate table config for a table",
notes = "This API returns the table config that matches the one you get
from 'GET /tables/{tableName}'."
+ " This allows us to validate table config before apply.")
- public String checkTableConfig(
+ public ObjectNode checkTableConfig(
Review Comment:
I checked this. But it's getting a little tricky to do it in a backward
compatible way. Since ConfigSuccessResponse extends SuccesResponse while this
function returns a custom object..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
