shaie commented on code in PR #841: URL: https://github.com/apache/lucene/pull/841#discussion_r897535013
########## lucene/facet/src/java/org/apache/lucene/facet/facetset/MatchingFacetSetsCounts.java: ########## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.facet.facetset; + +import java.io.IOException; +import java.util.Arrays; +import java.util.Collections; +import java.util.List; +import org.apache.lucene.document.LongPoint; +import org.apache.lucene.facet.FacetResult; +import org.apache.lucene.facet.Facets; +import org.apache.lucene.facet.FacetsCollector; +import org.apache.lucene.facet.LabelAndValue; +import org.apache.lucene.index.BinaryDocValues; +import org.apache.lucene.index.DocValues; +import org.apache.lucene.search.ConjunctionUtils; +import org.apache.lucene.search.DocIdSetIterator; +import org.apache.lucene.util.BytesRef; + +/** + * Returns the counts for each given {@link FacetSet} + * + * @lucene.experimental + */ +public class MatchingFacetSetsCounts extends Facets { + + private final FacetSetMatcher[] facetSetMatchers; + private final int[] counts; + private final String field; + private final int totCount; + + /** + * Constructs a new instance of matching facet set counts which calculates the countBytes for each + * given facet set matcher. + */ + public MatchingFacetSetsCounts( + String field, FacetsCollector hits, FacetSetMatcher... facetSetMatchers) throws IOException { + if (facetSetMatchers == null || facetSetMatchers.length == 0) { + throw new IllegalArgumentException("facetSetMatchers cannot be null or empty"); + } + if (areFacetSetMatcherDimensionsInconsistent(facetSetMatchers)) { + throw new IllegalArgumentException("All facet set matchers must be the same dimensionality"); + } + this.field = field; + this.facetSetMatchers = facetSetMatchers; + this.counts = new int[facetSetMatchers.length]; + this.totCount = count(field, hits.getMatchingDocs()); + } + + /** Counts from the provided field. */ + private int count(String field, List<FacetsCollector.MatchingDocs> matchingDocs) Review Comment: I see your point. I did that mainly to keep fields `final` to denote that are not changing after initialization. I realize there's a "side effect" of populating the counts array in the method which sucks (cause we can't return two values from a method). Is it better though over having all fields `final`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
