Fokko closed issue #428: Parallel Table.append
URL: https://github.com/apache/iceberg-python/issues/428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Fokko commented on issue #428:
URL: https://github.com/apache/iceberg-python/issues/428#issuecomment-2106799664
Fixed in #444
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
Fokko closed issue #346: Faster ingestion from Parquet
URL: https://github.com/apache/iceberg-python/issues/346
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
ajantha-bhat commented on PR #10318:
URL: https://github.com/apache/iceberg/pull/10318#issuecomment-2106836122
Flink flaky test: `TestIcebergSourceFailoverWithWatermarkExtractor >
testBoundedWithSavepoint FAILED`
--
This is an automated message from the Apache Git Service.
To resp
ajantha-bhat commented on PR #10318:
URL: https://github.com/apache/iceberg/pull/10318#issuecomment-2106836296
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
dependabot[bot] commented on PR #10318:
URL: https://github.com/apache/iceberg/pull/10318#issuecomment-2106836353
Sorry, only users with push access can use that command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
nastra closed issue #9846: Add documentation for views
URL: https://github.com/apache/iceberg/issues/9846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
marvinlanhenke commented on code in PR #367:
URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1598017270
##
crates/iceberg/src/expr/visitors/manifest_evaluator.rs:
##
@@ -103,98 +106,245 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_>
{
refe
marvinlanhenke commented on code in PR #373:
URL: https://github.com/apache/iceberg-rust/pull/373#discussion_r1598053461
##
crates/iceberg/src/scan.rs:
##
@@ -189,66 +195,20 @@ impl TableScan {
self.case_sensitive,
)?;
-let mut partition_filter_ca
nastra commented on issue #10326:
URL: https://github.com/apache/iceberg/issues/10326#issuecomment-2106958655
@911432 can you please elaborate what the goal here is? Everything you
described is already possible today.
--
This is an automated message from the Apache Git Service.
To respond
nastra commented on issue #10324:
URL: https://github.com/apache/iceberg/issues/10324#issuecomment-2106963864
> But if I tried to run a session with a different catalog such as demo_cat
it's able to show all databases and table referred to localcat catalog.
Do you have example output
Fokko commented on PR #10318:
URL: https://github.com/apache/iceberg/pull/10318#issuecomment-2107445552
https://github.com/dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
Fokko merged PR #10323:
URL: https://github.com/apache/iceberg/pull/10323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
ajantha-bhat commented on PR #10318:
URL: https://github.com/apache/iceberg/pull/10318#issuecomment-2107509238
Failure is independent of this change
```
* What went wrong:
Execution failed for task ':iceberg-gcp:compileTestJava'.
> Could not resolve all files for configuration
ajantha-bhat commented on PR #10318:
URL: https://github.com/apache/iceberg/pull/10318#issuecomment-2107510067
https://github.com/dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dependabot[bot] commented on PR #10318:
URL: https://github.com/apache/iceberg/pull/10318#issuecomment-2107510177
Sorry, only users with push access can use that command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
911432 commented on issue #10326:
URL: https://github.com/apache/iceberg/issues/10326#issuecomment-2107631861
I would like to store the query engine as a container image and the iceberg
table and iceberg catalog as a file system.
Let's take this [spark
page](https://iceberg.apache.org/do
ndrluis commented on PR #725:
URL: https://github.com/apache/iceberg-python/pull/725#issuecomment-2107649058
@syun64 Thank you for your review. I have made the requested change!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
syun64 commented on PR #728:
URL: https://github.com/apache/iceberg-python/pull/728#issuecomment-2107718666
Yes - even if its small, I think it would still be good to have a unit test
that verifies the behavior of the proposed table and transaction API
There are some tests in
https:/
911432 commented on issue #10326:
URL: https://github.com/apache/iceberg/issues/10326#issuecomment-2107762849
I know `Spark.sql.catalog.hadoop_prod.uri` doesn't seem to exist.
Similarly, for s3 and files, I hope
`Spark.sql.catalog..warehouse` is sufficient even without
`Spark.sql.catalog
911432 commented on issue #10326:
URL: https://github.com/apache/iceberg/issues/10326#issuecomment-2107764935
I know `Spark.sql.catalog.hadoop_prod.uri` doesn't seem to exist.
Similarly, for s3 and file, I hope
`Spark.sql.catalog..warehouse` is sufficient even without
`Spark.sql.catalog.
syun64 commented on code in PR #569:
URL: https://github.com/apache/iceberg-python/pull/569#discussion_r1598626280
##
pyiceberg/table/__init__.py:
##
@@ -443,6 +471,74 @@ def overwrite(
for data_file in data_files:
update_snapshot.append_dat
manuzhang commented on code in PR #10315:
URL: https://github.com/apache/iceberg/pull/10315#discussion_r1598686177
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkConfParser.java:
##
@@ -227,7 +225,26 @@ public ThisT tableProperty(String name) {
return sel
ZENOTME commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1598713751
##
crates/iceberg/src/transaction.rs:
##
@@ -121,6 +166,270 @@ impl<'a> Transaction<'a> {
}
}
+/// FastAppendAction is a transaction action for fast append d
ZENOTME commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1598744515
##
crates/iceberg/src/transaction.rs:
##
@@ -121,6 +166,270 @@ impl<'a> Transaction<'a> {
}
}
+/// FastAppendAction is a transaction action for fast append d
ZENOTME commented on PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#issuecomment-2108162712
Hi, I have tried to fix this PR. Some things may not be fixed well now:
1. https://github.com/apache/iceberg-rust/pull/349#discussion_r1580444775
I'm not sure whether my understa
syun64 commented on code in PR #569:
URL: https://github.com/apache/iceberg-python/pull/569#discussion_r1598823358
##
pyiceberg/table/__init__.py:
##
@@ -2931,14 +3161,52 @@ def _deleted_entries(self) -> List[ManifestEntry]:
return []
-class OverwriteFiles(_MergingS
sdd commented on code in PR #373:
URL: https://github.com/apache/iceberg-rust/pull/373#discussion_r1598826218
##
crates/iceberg/src/scan.rs:
##
@@ -302,13 +262,147 @@ impl TableScan {
arrow_reader_builder.build().read(self.plan_files().await?)
}
+}
+
+#[derive(De
amogh-jahagirdar merged PR #729:
URL: https://github.com/apache/iceberg-python/pull/729
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
sdd commented on code in PR #373:
URL: https://github.com/apache/iceberg-rust/pull/373#discussion_r1598841588
##
crates/iceberg/src/scan.rs:
##
@@ -189,66 +195,20 @@ impl TableScan {
self.case_sensitive,
)?;
-let mut partition_filter_cache = Parti
sdd commented on issue #124:
URL: https://github.com/apache/iceberg-rust/issues/124#issuecomment-2108489909
Using `try_for_each_concurrent` here rather than just spawning in a for loop
will allow us to tune the concurrncy as it accepts a max concurrent tasks
argument. I'd advocate for a dat
sdd commented on code in PR #373:
URL: https://github.com/apache/iceberg-rust/pull/373#discussion_r1598867675
##
crates/iceberg/src/scan.rs:
##
@@ -302,13 +262,147 @@ impl TableScan {
arrow_reader_builder.build().read(self.plan_files().await?)
}
+}
+
+#[derive(De
rodmeneses commented on code in PR #10179:
URL: https://github.com/apache/iceberg/pull/10179#discussion_r1598876459
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergSink.java:
##
@@ -0,0 +1,774 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
sfc-gh-dhuo commented on issue #723:
URL: https://github.com/apache/iceberg-python/issues/723#issuecomment-2108525436
Normally the abfss URI is expected to look like this, according to [azure
docs](https://learn.microsoft.com/en-us/azure/storage/blobs/data-lake-storage-introduction-abfs-uri)
singhpk234 commented on PR #10293:
URL: https://github.com/apache/iceberg/pull/10293#issuecomment-2108558359
> What do you think @muddyfish @singhpk234?
Sounds good, @amogh-jahagirdar !
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
singhpk234 commented on PR #10292:
URL: https://github.com/apache/iceberg/pull/10292#issuecomment-2108568399
> According to this PR https://github.com/apache/iceberg/pull/7914, it
doesn't seem that delete_orphan_files supports S3FileIO. If/when it does, it
still might not work with S3 Expre
amogh-jahagirdar commented on code in PR #10328:
URL: https://github.com/apache/iceberg/pull/10328#discussion_r1598902060
##
parquet/src/main/java/org/apache/iceberg/parquet/ReadConf.java:
##
@@ -186,27 +186,14 @@ private Map generateOffsetToStartPos(Schema
schema) {
ret
amogh-jahagirdar commented on code in PR #10328:
URL: https://github.com/apache/iceberg/pull/10328#discussion_r1598902060
##
parquet/src/main/java/org/apache/iceberg/parquet/ReadConf.java:
##
@@ -186,27 +186,14 @@ private Map generateOffsetToStartPos(Schema
schema) {
ret
amogh-jahagirdar commented on code in PR #10328:
URL: https://github.com/apache/iceberg/pull/10328#discussion_r1598971225
##
parquet/src/main/java/org/apache/iceberg/parquet/ReadConf.java:
##
@@ -186,27 +184,14 @@ private Map generateOffsetToStartPos(Schema
schema) {
ret
amogh-jahagirdar commented on code in PR #10328:
URL: https://github.com/apache/iceberg/pull/10328#discussion_r1598971225
##
parquet/src/main/java/org/apache/iceberg/parquet/ReadConf.java:
##
@@ -186,27 +184,14 @@ private Map generateOffsetToStartPos(Schema
schema) {
ret
aokolnychyi commented on code in PR #10311:
URL: https://github.com/apache/iceberg/pull/10311#discussion_r1598997615
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkConfParser.java:
##
@@ -197,6 +201,34 @@ private Duration toDuration(String time) {
}
}
amogh-jahagirdar commented on code in PR #10328:
URL: https://github.com/apache/iceberg/pull/10328#discussion_r1598999097
##
parquet/src/main/java/org/apache/iceberg/parquet/ReadConf.java:
##
@@ -186,27 +184,14 @@ private Map generateOffsetToStartPos(Schema
schema) {
ret
aokolnychyi commented on code in PR #10315:
URL: https://github.com/apache/iceberg/pull/10315#discussion_r1598999270
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkConfParser.java:
##
@@ -227,7 +225,26 @@ public ThisT tableProperty(String name) {
return s
aokolnychyi commented on code in PR #10311:
URL: https://github.com/apache/iceberg/pull/10311#discussion_r1599001671
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkConfParser.java:
##
@@ -70,6 +70,10 @@ public DurationConfParser durationConf() {
return new
aokolnychyi commented on code in PR #10311:
URL: https://github.com/apache/iceberg/pull/10311#discussion_r1599002997
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkReadConf.java:
##
@@ -302,14 +302,12 @@ public PlanningMode dataPlanningMode() {
return LOC
amogh-jahagirdar closed pull request #10328: Parquet: Remove redundant reading
of file metadata when determining starting positions of row groups
URL: https://github.com/apache/iceberg/pull/10328
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
aokolnychyi commented on code in PR #10311:
URL: https://github.com/apache/iceberg/pull/10311#discussion_r1599002997
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkReadConf.java:
##
@@ -302,14 +302,12 @@ public PlanningMode dataPlanningMode() {
return LOC
aokolnychyi merged PR #10149:
URL: https://github.com/apache/iceberg/pull/10149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@icebe
huaxingao commented on PR #10149:
URL: https://github.com/apache/iceberg/pull/10149#issuecomment-2108679771
Thanks @aokolnychyi @manuzhang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
danielcweeks commented on PR #10283:
URL: https://github.com/apache/iceberg/pull/10283#issuecomment-2108825075
@dimas-b I just put up https://github.com/apache/iceberg/pull/10329 to
address the field name encoding. This should also address the quotes issue as
well since it will be encoded.
aokolnychyi merged PR #10311:
URL: https://github.com/apache/iceberg/pull/10311
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@icebe
amogh-jahagirdar commented on PR #10283:
URL: https://github.com/apache/iceberg/pull/10283#issuecomment-2108850538
> Overall, I think it's better to fail fast where interoperability is a
concern as that's more important than supporting the full s3 key space.
After seeing a variety of
huaxingao commented on PR #10311:
URL: https://github.com/apache/iceberg/pull/10311#issuecomment-2108854132
Thanks @aokolnychyi @nastra
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
amogh-jahagirdar commented on code in PR #10329:
URL: https://github.com/apache/iceberg/pull/10329#discussion_r1599127317
##
core/src/test/java/org/apache/iceberg/TestLocationProvider.java:
##
@@ -285,4 +286,22 @@ public void testObjectStorageWithinTableLocation() {
assertT
syun64 commented on code in PR #330:
URL: https://github.com/apache/iceberg-python/pull/330#discussion_r1598837560
##
tests/table/test_init.py:
##
@@ -1125,3 +1128,122 @@ def test_serialize_commit_table_request() -> None:
deserialized_request =
CommitTableRequest.model_v
dependabot[bot] opened a new pull request, #730:
URL: https://github.com/apache/iceberg-python/pull/730
Bumps [pypa/cibuildwheel](https://github.com/pypa/cibuildwheel) from 2.17.0
to 2.18.0.
Release notes
Sourced from https://github.com/pypa/cibuildwheel/releases";>pypa/cibuildwhee
dependabot[bot] opened a new pull request, #731:
URL: https://github.com/apache/iceberg-python/pull/731
Bumps [griffe](https://github.com/mkdocstrings/griffe) from 0.44.0 to 0.45.0.
Release notes
Sourced from https://github.com/mkdocstrings/griffe/releases";>griffe's
releases.
dependabot[bot] opened a new pull request, #732:
URL: https://github.com/apache/iceberg-python/pull/732
Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from
9.5.21 to 9.5.22.
Release notes
Sourced from https://github.com/squidfunk/mkdocs-material/releases";>mk
dependabot[bot] opened a new pull request, #733:
URL: https://github.com/apache/iceberg-python/pull/733
Bumps [moto](https://github.com/getmoto/moto) from 5.0.6 to 5.0.7.
Changelog
Sourced from https://github.com/getmoto/moto/blob/master/CHANGELOG.md";>moto's
changelog.
5.0.
huaxingao opened a new pull request, #10330:
URL: https://github.com/apache/iceberg/pull/10330
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
bartash commented on PR #10278:
URL: https://github.com/apache/iceberg/pull/10278#issuecomment-2108929825
@nastra thanks for the review, could you push this in please when you get a
chance? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
jqin61 commented on code in PR #569:
URL: https://github.com/apache/iceberg-python/pull/569#discussion_r1599183250
##
pyiceberg/table/__init__.py:
##
@@ -2897,12 +2987,152 @@ def _commit(self) -> UpdatesAndRequirements:
),
(
AssertTabl
jqin61 commented on code in PR #569:
URL: https://github.com/apache/iceberg-python/pull/569#discussion_r1599183250
##
pyiceberg/table/__init__.py:
##
@@ -2897,12 +2987,152 @@ def _commit(self) -> UpdatesAndRequirements:
),
(
AssertTabl
jqin61 commented on code in PR #569:
URL: https://github.com/apache/iceberg-python/pull/569#discussion_r1599183250
##
pyiceberg/table/__init__.py:
##
@@ -2897,12 +2987,152 @@ def _commit(self) -> UpdatesAndRequirements:
),
(
AssertTabl
amogh-jahagirdar commented on code in PR #10199:
URL: https://github.com/apache/iceberg/pull/10199#discussion_r1599192267
##
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java:
##
@@ -316,6 +316,11 @@ void persistGlueTable(
.skipArchive(awsProp
danielcweeks commented on code in PR #10329:
URL: https://github.com/apache/iceberg/pull/10329#discussion_r1599193529
##
core/src/test/java/org/apache/iceberg/TestLocationProvider.java:
##
@@ -285,4 +286,22 @@ public void testObjectStorageWithinTableLocation() {
assertThat(
danielcweeks commented on code in PR #10329:
URL: https://github.com/apache/iceberg/pull/10329#discussion_r1599193529
##
core/src/test/java/org/apache/iceberg/TestLocationProvider.java:
##
@@ -285,4 +286,22 @@ public void testObjectStorageWithinTableLocation() {
assertThat(
amogh-jahagirdar commented on code in PR #10199:
URL: https://github.com/apache/iceberg/pull/10199#discussion_r1599192463
##
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java:
##
@@ -316,6 +316,11 @@ void persistGlueTable(
.skipArchive(awsProp
dimas-b commented on code in PR #10329:
URL: https://github.com/apache/iceberg/pull/10329#discussion_r1599203081
##
api/src/main/java/org/apache/iceberg/PartitionSpec.java:
##
@@ -189,7 +189,7 @@ public String partitionToPath(StructLike data) {
if (i > 0) {
sb.ap
dimas-b commented on code in PR #10329:
URL: https://github.com/apache/iceberg/pull/10329#discussion_r1599208577
##
core/src/test/java/org/apache/iceberg/TestLocationProvider.java:
##
@@ -285,4 +286,22 @@ public void testObjectStorageWithinTableLocation() {
assertThat(parts
dimas-b commented on code in PR #10329:
URL: https://github.com/apache/iceberg/pull/10329#discussion_r1599208577
##
core/src/test/java/org/apache/iceberg/TestLocationProvider.java:
##
@@ -285,4 +286,22 @@ public void testObjectStorageWithinTableLocation() {
assertThat(parts
huaxingao commented on PR #10330:
URL: https://github.com/apache/iceberg/pull/10330#issuecomment-2109008119
cc @aokolnychyi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
dimas-b commented on code in PR #10329:
URL: https://github.com/apache/iceberg/pull/10329#discussion_r1599215769
##
core/src/test/java/org/apache/iceberg/TestLocationProvider.java:
##
@@ -285,4 +286,22 @@ public void testObjectStorageWithinTableLocation() {
assertThat(parts
djouallah commented on issue #723:
URL: https://github.com/apache/iceberg-python/issues/723#issuecomment-2109038972
the URI is
`'abfss://account_name.dfs.core.windows.net/data/iceberg_dwh/scada/metadata/snap-2728627078701324745-0-7c1d442e-7321-46f8-aa06-5d5f94cde607.avro'`
btw it wor
dimas-b commented on PR #10283:
URL: https://github.com/apache/iceberg/pull/10283#issuecomment-2109039866
> I still feel we want to discourage (if not disallow) special characters in
paths due to cross compatibility issues.
I made a comment under #10329 proposing an escaping method th
stevenzwu commented on PR #10331:
URL: https://github.com/apache/iceberg/pull/10331#issuecomment-2109051590
Moved `DataStatistics` away from generic and use a type to distinguish btw
Map and Sketch statistics. One main reason is to support auto
migration/promotion of Map stats to Sketch if
stevenzwu commented on code in PR #10331:
URL: https://github.com/apache/iceberg/pull/10331#discussion_r1599242761
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/shuffle/AggregatedStatistics.java:
##
@@ -19,53 +19,87 @@
package org.apache.iceberg.flink.sink.sh
stevenzwu commented on code in PR #10331:
URL: https://github.com/apache/iceberg/pull/10331#discussion_r1599247256
##
flink/v1.19/build.gradle:
##
@@ -66,6 +66,8 @@ project(":iceberg-flink:iceberg-flink-${flinkMajorVersion}") {
exclude group: 'org.slf4j'
}
+imp
amogh-jahagirdar commented on code in PR #10332:
URL: https://github.com/apache/iceberg/pull/10332#discussion_r1599249297
##
aws/src/main/java/org/apache/iceberg/aws/HttpClientProperties.java:
##
@@ -52,6 +52,13 @@ public class HttpClientProperties implements Serializable {
p
amogh-jahagirdar commented on code in PR #10332:
URL: https://github.com/apache/iceberg/pull/10332#discussion_r1599254560
##
aws/src/main/java/org/apache/iceberg/aws/HttpClientProperties.java:
##
@@ -52,6 +52,13 @@ public class HttpClientProperties implements Serializable {
p
amogh-jahagirdar commented on code in PR #10332:
URL: https://github.com/apache/iceberg/pull/10332#discussion_r1599254560
##
aws/src/main/java/org/apache/iceberg/aws/HttpClientProperties.java:
##
@@ -52,6 +52,13 @@ public class HttpClientProperties implements Serializable {
p
stevenzwu commented on code in PR #10308:
URL: https://github.com/apache/iceberg/pull/10308#discussion_r1599253290
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/SingleThreadedIteratorSource.java:
##
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apa
flyrain commented on code in PR #10332:
URL: https://github.com/apache/iceberg/pull/10332#discussion_r1599301463
##
aws/src/main/java/org/apache/iceberg/aws/HttpClientProperties.java:
##
@@ -52,6 +52,13 @@ public class HttpClientProperties implements Serializable {
public sta
flyrain commented on PR #10332:
URL: https://github.com/apache/iceberg/pull/10332#issuecomment-2109204549
Thanks @amogh-jahagirdar for the review. Resolved your comments. Would you
like to take another look?
--
This is an automated message from the Apache Git Service.
To respond to the me
aajisaka commented on code in PR #10199:
URL: https://github.com/apache/iceberg/pull/10199#discussion_r1599418533
##
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java:
##
@@ -316,6 +316,11 @@ void persistGlueTable(
.skipArchive(awsProperties.g
aajisaka commented on code in PR #10199:
URL: https://github.com/apache/iceberg/pull/10199#discussion_r1599418688
##
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogTable.java:
##
@@ -206,6 +208,15 @@ public void testUpdateTable() {
.isEqualTo("EXTER
aajisaka commented on code in PR #10199:
URL: https://github.com/apache/iceberg/pull/10199#discussion_r1599419966
##
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java:
##
@@ -316,6 +316,11 @@ void persistGlueTable(
.skipArchive(awsProperties.g
pvary commented on code in PR #10179:
URL: https://github.com/apache/iceberg/pull/10179#discussion_r1599425277
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergSink.java:
##
@@ -0,0 +1,780 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
pvary commented on code in PR #10179:
URL: https://github.com/apache/iceberg/pull/10179#discussion_r1599426224
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/committer/SinkAggregator.java:
##
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software Foundation
pvary commented on code in PR #10179:
URL: https://github.com/apache/iceberg/pull/10179#discussion_r1599428479
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/committer/SinkAggregator.java:
##
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software Foundation
pvary commented on code in PR #10179:
URL: https://github.com/apache/iceberg/pull/10179#discussion_r1599429291
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/committer/SinkAggregator.java:
##
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software Foundation
pvary commented on code in PR #10179:
URL: https://github.com/apache/iceberg/pull/10179#discussion_r1599431142
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/committer/SinkCommittable.java:
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation
pvary commented on code in PR #10179:
URL: https://github.com/apache/iceberg/pull/10179#discussion_r1599432484
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/committer/SinkCommittableSerializer.java:
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software F
pvary commented on code in PR #10179:
URL: https://github.com/apache/iceberg/pull/10179#discussion_r1599433519
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/committer/SinkCommitter.java:
##
@@ -0,0 +1,439 @@
+/*
+ * Licensed to the Apache Software Foundation (
pvary commented on code in PR #10179:
URL: https://github.com/apache/iceberg/pull/10179#discussion_r1599434778
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/committer/SinkCommitter.java:
##
@@ -0,0 +1,439 @@
+/*
+ * Licensed to the Apache Software Foundation (
pvary commented on code in PR #10179:
URL: https://github.com/apache/iceberg/pull/10179#discussion_r1599434778
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/committer/SinkCommitter.java:
##
@@ -0,0 +1,439 @@
+/*
+ * Licensed to the Apache Software Foundation (
pvary commented on code in PR #10179:
URL: https://github.com/apache/iceberg/pull/10179#discussion_r1599436116
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/committer/SinkCommitter.java:
##
@@ -0,0 +1,439 @@
+/*
+ * Licensed to the Apache Software Foundation (
pvary commented on code in PR #10179:
URL: https://github.com/apache/iceberg/pull/10179#discussion_r1599438514
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/writer/IcebergSinkWriter.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation
pvary commented on code in PR #10179:
URL: https://github.com/apache/iceberg/pull/10179#discussion_r1599443353
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkIcebergSinkV2.java:
##
@@ -140,8 +140,8 @@ public void testCheckAndGetEqualityFieldIds() {
pvary commented on PR #10179:
URL: https://github.com/apache/iceberg/pull/10179#issuecomment-2109381711
Looks promising to me. @stevenzwu, could you please review too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
1 - 100 of 101 matches
Mail list logo
