amogh-jahagirdar commented on code in PR #10328:
URL: https://github.com/apache/iceberg/pull/10328#discussion_r1598971225
##########
parquet/src/main/java/org/apache/iceberg/parquet/ReadConf.java:
##########
@@ -186,27 +184,14 @@ private Map<Long, Long> generateOffsetToStartPos(Schema
schema) {
return null;
}
- FileDecryptionProperties decryptionProperties =
- (options == null) ? null : options.getDecryptionProperties();
-
- ParquetReadOptions readOptions =
-
ParquetReadOptions.builder().withDecryption(decryptionProperties).build();
-
- try (ParquetFileReader fileReader = newReader(file, readOptions)) {
Review Comment:
Removing the `newReader` is really the main part of this change. newReader
will instantiate a new ParquetFileReader which will perform an I/O and re-read
the footer which we already read in the readConf constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
