aokolnychyi commented on code in PR #10311:
URL: https://github.com/apache/iceberg/pull/10311#discussion_r1598997615
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkConfParser.java:
##########
@@ -197,6 +201,34 @@ private Duration toDuration(String time) {
}
}
+ class EnumConfParser<T extends Enum<T>> extends
ConfParser<EnumConfParser<T>, T> {
+ private T defaultValue;
+ private final Function<String, T> toEnum;
Review Comment:
Minor: We usually have final vars before mutable. Can we switch the order of
these two?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
