dimas-b commented on code in PR #10329:
URL: https://github.com/apache/iceberg/pull/10329#discussion_r1599203081
##########
api/src/main/java/org/apache/iceberg/PartitionSpec.java:
##########
@@ -189,7 +189,7 @@ public String partitionToPath(StructLike data) {
if (i > 0) {
sb.append("/");
}
- sb.append(field.name()).append("=").append(escape(valueString));
+ sb.append(escape(field.name())).append("=").append(escape(valueString));
Review Comment:
This fix looks reasonable to me as far as #10279 is concerned.
However, this will cause partition paths to change in existing tables that
have special characters that previously did not cause correctness issues, for
example quotes (`"`). So new files under the same partition key will not share
a common prefix with old files under that same partition key... Just want to
make sure this is intentional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
