amogh-jahagirdar commented on code in PR #10199:
URL: https://github.com/apache/iceberg/pull/10199#discussion_r1599192267
##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java:
##########
@@ -316,6 +316,11 @@ void persistGlueTable(
.skipArchive(awsProperties.glueCatalogSkipArchive())
.tableInput(
TableInput.builder()
+ // Keep the existing table description
+ .description(glueTable.description())
+ // This overwrites the existing table description if
there's a comment like
+ // ALTER TABLE prod.db.sample SET TBLPROPERTIES (
+ // 'comment' = 'A table description.')
Review Comment:
> This overwrites the existing table description
You mean `applyMutation` overwrites right? I'd just explicitly say that
##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java:
##########
@@ -316,6 +316,11 @@ void persistGlueTable(
.skipArchive(awsProperties.glueCatalogSkipArchive())
.tableInput(
TableInput.builder()
+ // Keep the existing table description
+ .description(glueTable.description())
+ // This overwrites the existing table description if
there's a comment like
+ // ALTER TABLE prod.db.sample SET TBLPROPERTIES (
+ // 'comment' = 'A table description.')
Review Comment:
> This overwrites the existing table description
You mean `applyMutation` overwrites right? I'd just explicitly say that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
