amogh-jahagirdar commented on code in PR #10199:
URL: https://github.com/apache/iceberg/pull/10199#discussion_r1599192463
##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java:
##########
@@ -316,6 +316,11 @@ void persistGlueTable(
.skipArchive(awsProperties.glueCatalogSkipArchive())
.tableInput(
TableInput.builder()
+ // Keep the existing table description
+ .description(glueTable.description())
+ // This overwrites the existing table description if
there's a comment like
Review Comment:
> This overwrites the existing table description
You mean `applyMutation` overwrites right? I'd just explicitly say that on
the comment in 319
```
// Explicitly keep the existing table description since `applyMutation` will
clear the table description
```
##########
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogTable.java:
##########
@@ -206,6 +208,15 @@ public void testUpdateTable() {
.isEqualTo("EXTERNAL_TABLE");
assertThat(response.table().storageDescriptor().columns()).hasSameSizeAs(schema.columns());
assertThat(response.table().partitionKeys()).hasSameSizeAs(partitionSpec.fields());
+ assertThat(response.table().description()).isEqualTo(description);
+
+ // Make sure adding a comment updates the existing table description
+ String comment = "Test comment";
Review Comment:
Nit: I think if you rename the variable you can probably get rid of the
inline comment since it'll be clear.
Maybe just call it `updatedDescription` or `updatedComment` and then you
won't need the inline comment since the test is clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
