flyrain commented on code in PR #10332:
URL: https://github.com/apache/iceberg/pull/10332#discussion_r1599301463
##########
aws/src/main/java/org/apache/iceberg/aws/HttpClientProperties.java:
##########
@@ -52,6 +52,13 @@ public class HttpClientProperties implements Serializable {
public static final String CLIENT_TYPE_URLCONNECTION = "urlconnection";
public static final String CLIENT_TYPE_DEFAULT = CLIENT_TYPE_APACHE;
+
+ /**
+ * Used to configure the proxy endpoint. Used by both {@link
+ *
software.amazon.awssdk.http.urlconnection.UrlConnectionHttpClient.Builder} and
{@link
+ * software.amazon.awssdk.http.apache.ApacheHttpClient.Builder}
+ */
+ public static final String PROXY_ENDPOINT = "http-client.proxy-endpoint";
Review Comment:
Will add it to the doc. I think it's fine to apply to other clients due to
following two reasons.
1. If s3 needs it, most likely other clients need it as well.
2. They are not necessarily in the same catalog configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
