pvary commented on code in PR #10179:
URL: https://github.com/apache/iceberg/pull/10179#discussion_r1599443353
##########
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkIcebergSinkV2.java:
##########
@@ -140,8 +140,8 @@ public void testCheckAndGetEqualityFieldIds() {
DataStream<Row> dataStream =
env.addSource(new BoundedTestSource<>(ImmutableList.of()),
ROW_TYPE_INFO);
- FlinkSink.Builder builder =
- FlinkSink.forRow(dataStream, SimpleDataUtil.FLINK_SCHEMA).table(table);
+ IcebergSink.Builder builder =
Review Comment:
What was the original intention of this test? Why it was V2? Do we still has
test for that case?
Same question for `TestFlinkIcebergSinkV2Base`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
