amogh-jahagirdar commented on code in PR #10328:
URL: https://github.com/apache/iceberg/pull/10328#discussion_r1598902060
##########
parquet/src/main/java/org/apache/iceberg/parquet/ReadConf.java:
##########
@@ -186,27 +186,14 @@ private Map<Long, Long> generateOffsetToStartPos(Schema
schema) {
return null;
}
- FileDecryptionProperties decryptionProperties =
- (options == null) ? null : options.getDecryptionProperties();
-
- ParquetReadOptions readOptions =
-
ParquetReadOptions.builder().withDecryption(decryptionProperties).build();
Review Comment:
These decryption properties should already be passed in via the normal
options when doing the read to begin with. We already read the row group
metadata in the ReadConf constructor. No need for the extra I/O as far as I can
tell
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
