aajisaka commented on code in PR #10199:
URL: https://github.com/apache/iceberg/pull/10199#discussion_r1599418533
##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java:
##########
@@ -316,6 +316,11 @@ void persistGlueTable(
.skipArchive(awsProperties.glueCatalogSkipArchive())
.tableInput(
TableInput.builder()
+ // Keep the existing table description
+ .description(glueTable.description())
+ // This overwrites the existing table description if
there's a comment like
Review Comment:
> You mean applyMutation overwrites right?
Yes.
> // Explicitly keep the existing table description since `applyMutation`
will clear the table description
This is not right. `applyMutation` won't clear the table description, it
overwrites the description only if the comment is specified by the user as
below:
```
ALTER TABLE prod.db.sample SET TBLPROPERTIES ('comment' = 'A table
description.')
```
I want to explain why I need to call `.description(glueTable.description())`
first and call `applyMutation` second. If the order is reversed, user cannot
update the table description by using the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
