Re: [PR] Core: Improvements around View catalog tests [iceberg]

rdblue commented on PR #8865: URL: https://github.com/apache/iceberg/pull/8865#issuecomment-1773525223 Thanks, @nastra! Looks like this is also included in #7913 so it's good to get this in. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Core: Improvements around View catalog tests [iceberg]

rdblue merged PR #8865: URL: https://github.com/apache/iceberg/pull/8865 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Core: Improvements around View catalog tests [iceberg]

rdblue commented on code in PR #8865: URL: https://github.com/apache/iceberg/pull/8865#discussion_r1367559524 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -132,15 +144,21 @@ public void completeCreateView() { .withQuery("trino", "select

Re: [PR] Core: Improvements around View catalog tests [iceberg]

nastra commented on code in PR #8865: URL: https://github.com/apache/iceberg/pull/8865#discussion_r1365171588 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -225,8 +243,9 @@ public void createViewErrorCases() { .withQuery(trino.di

Re: [PR] Core: Improvements around View catalog tests [iceberg]

nastra commented on code in PR #8865: URL: https://github.com/apache/iceberg/pull/8865#discussion_r1365154084 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -1446,7 +1544,14 @@ public void updateViewLocationConflict() { // the view was already

Re: [PR] Core: Improvements around View catalog tests [iceberg]

nastra commented on code in PR #8865: URL: https://github.com/apache/iceberg/pull/8865#discussion_r1364159020 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -132,15 +144,21 @@ public void completeCreateView() { .withQuery("trino", "select

Re: [PR] Core: Improvements around View catalog tests [iceberg]

nastra commented on code in PR #8865: URL: https://github.com/apache/iceberg/pull/8865#discussion_r1364156037 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -225,8 +243,9 @@ public void createViewErrorCases() { .withQuery(trino.di

Re: [PR] Core: Improvements around View catalog tests [iceberg]

nastra commented on code in PR #8865: URL: https://github.com/apache/iceberg/pull/8865#discussion_r1364145699 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -132,15 +137,21 @@ public void completeCreateView() { .withQuery("trino", "select

Re: [PR] Core: Improvements around View catalog tests [iceberg]

nastra commented on code in PR #8865: URL: https://github.com/apache/iceberg/pull/8865#discussion_r1364135298 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -132,15 +144,21 @@ public void completeCreateView() { .withQuery("trino", "select

Re: [PR] Core: Improvements around View catalog tests [iceberg]

rdblue commented on code in PR #8865: URL: https://github.com/apache/iceberg/pull/8865#discussion_r1364092801 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -132,15 +144,21 @@ public void completeCreateView() { .withQuery("trino", "select

Re: [PR] Core: Improvements around View catalog tests [iceberg]

rdblue commented on code in PR #8865: URL: https://github.com/apache/iceberg/pull/8865#discussion_r1364091288 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -225,8 +243,9 @@ public void createViewErrorCases() { .withQuery(trino.di

Re: [PR] Core: Improvements around View catalog tests [iceberg]

rdblue commented on code in PR #8865: URL: https://github.com/apache/iceberg/pull/8865#discussion_r1364089610 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -1446,7 +1544,14 @@ public void updateViewLocationConflict() { // the view was already

Re: [PR] Core: Improvements around View catalog tests [iceberg]

rdblue commented on code in PR #8865: URL: https://github.com/apache/iceberg/pull/8865#discussion_r1364084512 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -132,15 +137,21 @@ public void completeCreateView() { .withQuery("trino", "select

Re: [PR] Core: Improvements around View catalog tests [iceberg]

ajantha-bhat commented on code in PR #8865: URL: https://github.com/apache/iceberg/pull/8865#discussion_r1363931200 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -56,10 +59,16 @@ public abstract class ViewCatalogTests

Re: [PR] Core: Improvements around View catalog tests [iceberg]

nastra commented on code in PR #8865: URL: https://github.com/apache/iceberg/pull/8865#discussion_r1363926224 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -664,6 +684,41 @@ public void renameViewTargetAlreadyExistsAsTable() { .hasMessageCon

Re: [PR] Core: Improvements around View catalog tests [iceberg]

nastra commented on code in PR #8865: URL: https://github.com/apache/iceberg/pull/8865#discussion_r1363922938 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -56,10 +59,16 @@ public abstract class ViewCatalogTests

Re: [PR] Core: Improvements around View catalog tests [iceberg]

nastra commented on code in PR #8865: URL: https://github.com/apache/iceberg/pull/8865#discussion_r1363651962 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -132,15 +137,21 @@ public void completeCreateView() { .withQuery("trino", "select

[PR] Core: Improvements around View catalog tests [iceberg]

nastra opened a new pull request, #8865: URL: https://github.com/apache/iceberg/pull/8865 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai