nastra commented on code in PR #8865:
URL: https://github.com/apache/iceberg/pull/8865#discussion_r1364145699


##########
core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java:
##########
@@ -132,15 +137,21 @@ public void completeCreateView() {
             .withQuery("trino", "select * from ns.tbl using X")
             .withProperty("prop1", "val1")
             .withProperty("prop2", "val2")
-            .withLocation("file://tmp/ns/view")
+            .withLocation("file:///tmp/ns/view")

Review Comment:
   yes this was invalid, but I think it's still better to not directly rely on 
hardcoded directories under `/tmp` as that might interfere with other tests 
(running in parallel).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to