ajantha-bhat commented on code in PR #8865:
URL: https://github.com/apache/iceberg/pull/8865#discussion_r1363931200
##########
core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java:
##########
@@ -56,10 +59,16 @@ public abstract class ViewCatalogTests<C extends
ViewCatalog & SupportsNamespace
protected abstract Catalog tableCatalog();
+ @TempDir private Path tempDir;
Review Comment:
Ack.
For me `mkdir` was failing when we directly use the directories outside
`tmp`, for example `updated_tmp`.
```
org.apache.iceberg.exceptions.RuntimeIOException: Failed to create file:
file:/updated_tmp/ns/view/metadata/00001-b53ce176-f85d-47ba-95db-f571fe7f95a0.gz.metadata.json
at
org.apache.iceberg.hadoop.HadoopOutputFile.createOrOverwrite(HadoopOutputFile.java:87)
at
org.apache.iceberg.view.ViewMetadataParser.internalWrite(ViewMetadataParser.java:181)
at
org.apache.iceberg.view.ViewMetadataParser.overwrite(ViewMetadataParser.java:161)
at
org.apache.iceberg.view.BaseViewOperations.writeNewMetadata(BaseViewOperations.java:139)
at
org.apache.iceberg.view.BaseViewOperations.writeNewMetadataIfRequired(BaseViewOperations.java:147)
at
org.apache.iceberg.nessie.NessieViewOperations.doCommit(NessieViewOperations.java:127)
at
org.apache.iceberg.view.BaseViewOperations.commit(BaseViewOperations.java:123)
at
org.apache.iceberg.view.SetViewLocation.lambda$commit$0(SetViewLocation.java:68)
at
org.apache.iceberg.util.Tasks$Builder.runTaskWithRetry(Tasks.java:413)
at
org.apache.iceberg.util.Tasks$Builder.runSingleThreaded(Tasks.java:219)
at org.apache.iceberg.util.Tasks$Builder.run(Tasks.java:203)
at org.apache.iceberg.util.Tasks$Builder.run(Tasks.java:196)
at
org.apache.iceberg.view.SetViewLocation.commit(SetViewLocation.java:66)
at
org.apache.iceberg.view.ViewCatalogTests.updateViewLocation(ViewCatalogTests.java:1480)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
at
org.projectnessie.junit.engine.MultiEnvTestEngine.execute(MultiEnvTestEngine.java:67)
Caused by: java.io.IOException: Mkdirs failed to create
file:/updated_tmp/ns/view/metadata (exists=false,
cwd=file:/Users/ajantha/Documents/workspace/icebergWorkspace/iceberg/nessie)
at
org.apache.hadoop.fs.ChecksumFileSystem.create(ChecksumFileSystem.java:455)
at
org.apache.hadoop.fs.ChecksumFileSystem.create(ChecksumFileSystem.java:440)
at org.apache.hadoop.fs.FileSystem.create(FileSystem.java:911)
at org.apache.hadoop.fs.FileSystem.create(FileSystem.java:892)
at org.apache.hadoop.fs.FileSystem.create(FileSystem.java:789)
at
org.apache.iceberg.hadoop.HadoopOutputFile.createOrOverwrite(HadoopOutputFile.java:85)
... 18 more
```
So, I am neutral about changing it in CatalogTests as it only uses `tmp`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
