nastra commented on code in PR #8865:
URL: https://github.com/apache/iceberg/pull/8865#discussion_r1363922938


##########
core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java:
##########
@@ -56,10 +59,16 @@ public abstract class ViewCatalogTests<C extends 
ViewCatalog & SupportsNamespace
 
   protected abstract Catalog tableCatalog();
 
+  @TempDir private Path tempDir;

Review Comment:
   previously we were referring directly to the `tmp` dir (similar to 
`CatalogTests`), but it's better to use a randomly generated directory. I'll 
have a follow-up PR to also use a randomly generated temp dir for `CatalogTests`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to