nastra commented on code in PR #8865:
URL: https://github.com/apache/iceberg/pull/8865#discussion_r1364159020
##########
core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java:
##########
@@ -132,15 +144,21 @@ public void completeCreateView() {
.withQuery("trino", "select * from ns.tbl using X")
.withProperty("prop1", "val1")
.withProperty("prop2", "val2")
- .withLocation("file://tmp/ns/view")
+ .withLocation(location)
.create();
assertThat(view).isNotNull();
assertThat(catalog().viewExists(identifier)).as("View should
exist").isTrue();
+ assertThat(((BaseView)
view).operations().current().metadataFileLocation()).isNotNull();
+
+ if (!overridesRequestedLocation()) {
+ assertThat(view.location()).isEqualTo(location);
+ } else {
+ assertThat(view.location()).isNotNull();
Review Comment:
also I don't think we fail for tables with a REST catalog when the REST
catalog overrides the given location
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
