rdblue commented on code in PR #8865:
URL: https://github.com/apache/iceberg/pull/8865#discussion_r1364092801
##########
core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java:
##########
@@ -132,15 +144,21 @@ public void completeCreateView() {
.withQuery("trino", "select * from ns.tbl using X")
.withProperty("prop1", "val1")
.withProperty("prop2", "val2")
- .withLocation("file://tmp/ns/view")
+ .withLocation(location)
.create();
assertThat(view).isNotNull();
assertThat(catalog().viewExists(identifier)).as("View should
exist").isTrue();
+ assertThat(((BaseView)
view).operations().current().metadataFileLocation()).isNotNull();
+
+ if (!overridesRequestedLocation()) {
+ assertThat(view.location()).isEqualTo(location);
+ } else {
+ assertThat(view.location()).isNotNull();
Review Comment:
Why do we allow overriding the location? Shouldn't the catalog fail if it
chooses not to allow a custom location?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
