rdblue commented on code in PR #8865:
URL: https://github.com/apache/iceberg/pull/8865#discussion_r1364091288
##########
core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java:
##########
@@ -225,8 +243,9 @@ public void createViewErrorCases() {
.withQuery(trino.dialect(), trino.sql())
.withQuery(trino.dialect(), trino.sql())
.create())
- .isInstanceOf(IllegalArgumentException.class)
- .hasMessage("Invalid view version: Cannot add multiple queries for
dialect trino");
+ .isInstanceOf(Exception.class)
Review Comment:
I don't think this is correct. We should never allow ANY exception to be
valid. Why is `IllegalArgumentException` not the correct one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
