rdblue commented on code in PR #8865:
URL: https://github.com/apache/iceberg/pull/8865#discussion_r1364089610
##########
core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java:
##########
@@ -1446,7 +1544,14 @@ public void updateViewLocationConflict() {
// the view was already dropped concurrently
assertThatThrownBy(() ->
updateViewLocation.setLocation("new-location").commit())
- .isInstanceOf(CommitFailedException.class)
- .hasMessageContaining("Cannot commit");
+ .satisfiesAnyOf(
+ throwable ->
+ assertThat(throwable)
+ .isInstanceOf(NoSuchViewException.class)
+ .hasMessageContaining("View does not exist: ns.view"),
+ throwable ->
+ assertThat(throwable)
+ .isInstanceOf(CommitFailedException.class)
Review Comment:
It seems suspicious to me that both of these are allowed. Why shouldn't we
standardize on `NoSuchViewException`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
