nastra commented on code in PR #8865:
URL: https://github.com/apache/iceberg/pull/8865#discussion_r1364156037
##########
core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java:
##########
@@ -225,8 +243,9 @@ public void createViewErrorCases() {
.withQuery(trino.dialect(), trino.sql())
.withQuery(trino.dialect(), trino.sql())
.create())
- .isInstanceOf(IllegalArgumentException.class)
- .hasMessage("Invalid view version: Cannot add multiple queries for
dialect trino");
+ .isInstanceOf(Exception.class)
Review Comment:
this one particularly fails with REST view catalog in `CatalogHandlers`
[here](https://github.com/apache/iceberg/blob/c7ee7b45257f852c4e72ca90271df6505a5df92c/core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java#L428):
```
Expecting actual throwable to be an instance of:
java.lang.IllegalArgumentException
but was:
org.apache.iceberg.exceptions.BadRequestException: Malformed request:
Invalid view version: Cannot add multiple queries for dialect trino
```
I'm open to better ideas on how we could solve this for this particular test
case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
