nastra commented on code in PR #8865:
URL: https://github.com/apache/iceberg/pull/8865#discussion_r1365154084
##########
core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java:
##########
@@ -1446,7 +1544,14 @@ public void updateViewLocationConflict() {
// the view was already dropped concurrently
assertThatThrownBy(() ->
updateViewLocation.setLocation("new-location").commit())
- .isInstanceOf(CommitFailedException.class)
- .hasMessageContaining("Cannot commit");
+ .satisfiesAnyOf(
+ throwable ->
+ assertThat(throwable)
+ .isInstanceOf(NoSuchViewException.class)
+ .hasMessageContaining("View does not exist: ns.view"),
+ throwable ->
+ assertThat(throwable)
+ .isInstanceOf(CommitFailedException.class)
Review Comment:
agreed, I think it's better to standardize on `NoSuchViewException` in this
case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
