Re: [I] catalog table-default and table-override properties are not supported in CREATE_OR_REPLACE operation in IRC [iceberg]

2025-03-13 Thread via GitHub
puchengy commented on issue #12506: URL: https://github.com/apache/iceberg/issues/12506#issuecomment-2723803584 I looked a bit more, I think the issue is at this line https://github.com/apache/iceberg/blame/7d0395d4b6f8d690d70910fe2018a459582960e3/core/src/main/java/org/apache/iceberg/rest/C

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

2025-03-13 Thread via GitHub
rdblue commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r1994428498 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -543,6 +561,120 @@ public int hashCode() { } } + public static class GeometryType extends Pr

Re: [PR] Core: JDBCCatalog's dropView() should purge metadata files if GC is enabled [iceberg]

2025-03-13 Thread via GitHub
ebyhr commented on code in PR #12511: URL: https://github.com/apache/iceberg/pull/12511#discussion_r1994659921 ## core/src/test/java/org/apache/iceberg/jdbc/TestJdbcViewCatalog.java: ## @@ -138,4 +142,50 @@ public void testCommitExceptionWithMessage() { .hasMessageSta

[PR] feat: Add `SnapshotSummaries` [iceberg-rust]

2025-03-13 Thread via GitHub
jonathanc-n opened a new pull request, #1085: URL: https://github.com/apache/iceberg-rust/pull/1085 ## Which issue does this PR close? - Related to #724 ## What changes are included in this PR? This is the building block to implementing snapshot summaries. Most of th

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

2025-03-13 Thread via GitHub
rdblue commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r1994448801 ## core/src/main/java/org/apache/iceberg/util/GeometryUtil.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more con

Re: [PR] Core: JDBCCatalog's dropView() should purge metadata files if GC is enabled [iceberg]

2025-03-13 Thread via GitHub
ebyhr commented on code in PR #12511: URL: https://github.com/apache/iceberg/pull/12511#discussion_r1994659921 ## core/src/test/java/org/apache/iceberg/jdbc/TestJdbcViewCatalog.java: ## @@ -138,4 +142,50 @@ public void testCommitExceptionWithMessage() { .hasMessageSta

Re: [PR] Core: JDBCCatalog's dropView() should purge metadata files if GC is enabled [iceberg]

2025-03-13 Thread via GitHub
ebyhr commented on code in PR #12511: URL: https://github.com/apache/iceberg/pull/12511#discussion_r1994676612 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java: ## @@ -612,6 +613,14 @@ public boolean dropView(TableIdentifier identifier) { throw new Unsupport

Re: [PR] Add context to `PopulatedDeleteFileIndex` [iceberg-rust]

2025-03-13 Thread via GitHub
liurenjie1024 merged PR #1084: URL: https://github.com/apache/iceberg-rust/pull/1084 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [I] [1.7.1] Getting java.lang.NoSuchMethodError org.apache.iceberg.util.JsonUtil.mapper() With Hive catalog [iceberg]

2025-03-13 Thread via GitHub
RussellSpitzer commented on issue #12521: URL: https://github.com/apache/iceberg/issues/12521#issuecomment-2722395059 How are you providing libraries? This definitely seems like a classpath issue -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Add context to `PopulatedDeleteFileIndex` [iceberg-rust]

2025-03-13 Thread via GitHub
jonathanc-n commented on PR #1084: URL: https://github.com/apache/iceberg-rust/pull/1084#issuecomment-2723245930 @liurenjie1024 Thanks for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Add context to `PopulatedDeleteFileIndex` [iceberg-rust]

2025-03-13 Thread via GitHub
jonathanc-n commented on PR #1084: URL: https://github.com/apache/iceberg-rust/pull/1084#issuecomment-2723274184 I guess `fmt` didn't like the `///` at the end 😆 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Add context to `PopulatedDeleteFileIndex` [iceberg-rust]

2025-03-13 Thread via GitHub
liurenjie1024 commented on code in PR #1084: URL: https://github.com/apache/iceberg-rust/pull/1084#discussion_r1994582627 ## crates/iceberg/src/delete_file_index.rs: ## @@ -94,6 +94,14 @@ impl DeleteFileIndex { } impl PopulatedDeleteFileIndex { +/// Creates a new populat

Re: [PR] feat: Add conversion from `FileMetaData` to `ParquetMetadata` [iceberg-rust]

2025-03-13 Thread via GitHub
liurenjie1024 merged PR #1074: URL: https://github.com/apache/iceberg-rust/pull/1074 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [I] Consolidate methods of converting parquet file to data file builder. [iceberg-rust]

2025-03-13 Thread via GitHub
liurenjie1024 closed issue #1033: Consolidate methods of converting parquet file to data file builder. URL: https://github.com/apache/iceberg-rust/issues/1033 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] Consolidate methods of converting parquet file to data file builder. [iceberg-rust]

2025-03-13 Thread via GitHub
liurenjie1024 closed issue #1033: Consolidate methods of converting parquet file to data file builder. URL: https://github.com/apache/iceberg-rust/issues/1033 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

2025-03-13 Thread via GitHub
Kontinuation commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r1994570257 ## core/src/main/java/org/apache/iceberg/SingleValueParser.java: ## @@ -335,6 +349,13 @@ public static void toJson(Type type, Object defaultValue, JsonGenerator

Re: [PR] Scan Delete Support Part 5: Positional Delete Parsing [iceberg-rust]

2025-03-13 Thread via GitHub
jonathanc-n commented on code in PR #1011: URL: https://github.com/apache/iceberg-rust/pull/1011#discussion_r1994526608 ## crates/iceberg/src/arrow/delete_file_manager.rs: ## @@ -0,0 +1,638 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] feat: Add conversion from `FileMetaData` to `ParquetMetadata` [iceberg-rust]

2025-03-13 Thread via GitHub
jonathanc-n commented on PR #1074: URL: https://github.com/apache/iceberg-rust/pull/1074#issuecomment-2723182986 @Xuanwo @liurenjie1024 Should be fine now. Thanks for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Spark: Add some tests for variant fixup [iceberg]

2025-03-13 Thread via GitHub
XBaith commented on code in PR #12497: URL: https://github.com/apache/iceberg/pull/12497#discussion_r1994571112 ## api/src/main/java/org/apache/iceberg/variants/VariantMetadata.java: ## @@ -54,6 +54,10 @@ static VariantMetadata from(ByteBuffer buffer) { return SerializedMet

Re: [PR] Parquet: Add variant array reader in Parquet [iceberg]

2025-03-13 Thread via GitHub
aihuaxu commented on code in PR #12512: URL: https://github.com/apache/iceberg/pull/12512#discussion_r1994559471 ## core/src/main/java/org/apache/iceberg/variants/ShreddedArray.java: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

2025-03-13 Thread via GitHub
Kontinuation commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r1994552835 ## api/src/test/java/org/apache/iceberg/types/TestSerializableTypes.java: ## @@ -63,7 +63,14 @@ public void testEqualTypes() throws Exception { Types.

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

2025-03-13 Thread via GitHub
Kontinuation commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r1994555755 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -543,6 +563,122 @@ public int hashCode() { } } + public static class GeometryType exte

Re: [I] Add more variants to `ErrorKind` [iceberg-rust]

2025-03-13 Thread via GitHub
jonathanc-n commented on issue #1038: URL: https://github.com/apache/iceberg-rust/issues/1038#issuecomment-2723127035 > I propose to add: > > pub enum ErrorKind { > Unexpected, > DataInvalid, > FeatureUnsupported, > > +NamespaceNotFound, > +Na

Re: [I] Replace `humantime` crate with `jiff`. [iceberg-rust]

2025-03-13 Thread via GitHub
liurenjie1024 closed issue #1075: Replace `humantime` crate with `jiff`. URL: https://github.com/apache/iceberg-rust/issues/1075 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] Add context to `PopulatedDeleteFileIndex` [iceberg-rust]

2025-03-13 Thread via GitHub
jonathanc-n opened a new pull request, #1084: URL: https://github.com/apache/iceberg-rust/pull/1084 ## Which issue does this PR close? - Closes #. ## What changes are included in this PR? Added some doc for `PopulatedDeleteFileIndex` -- This is an automated message

Re: [I] Split transaction mod to multi files mod. [iceberg-rust]

2025-03-13 Thread via GitHub
liurenjie1024 closed issue #980: Split transaction mod to multi files mod. URL: https://github.com/apache/iceberg-rust/issues/980 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] refactor: Split transaction module [iceberg-rust]

2025-03-13 Thread via GitHub
liurenjie1024 merged PR #1080: URL: https://github.com/apache/iceberg-rust/pull/1080 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] Scan Delete Support Part 4: Delete File Loading; Skeleton for Processing [iceberg-rust]

2025-03-13 Thread via GitHub
jonathanc-n commented on code in PR #982: URL: https://github.com/apache/iceberg-rust/pull/982#discussion_r1994474161 ## crates/iceberg/src/arrow/delete_file_manager.rs: ## @@ -0,0 +1,564 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor l

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

2025-03-13 Thread via GitHub
rdblue commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r1994425431 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -543,6 +563,122 @@ public int hashCode() { } } + public static class GeometryType extends Pr

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

2025-03-13 Thread via GitHub
rdblue commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r1994438996 ## api/src/main/java/org/apache/iceberg/types/EdgeInterpolationAlgorithm.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

2025-03-13 Thread via GitHub
rdblue commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r1994453224 ## core/src/test/java/org/apache/iceberg/TestSingleValueParser.java: ## @@ -157,6 +167,15 @@ public void testInvalidTimestamptz() { .hasMessageStartingWith("C

Re: [PR] Core: Fix move/update/makeRequire/makeOptional fail after rename schema (#10830) [iceberg]

2025-03-13 Thread via GitHub
github-actions[bot] commented on PR #12202: URL: https://github.com/apache/iceberg/pull/12202#issuecomment-2722981678 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] WIP: File format api [iceberg]

2025-03-13 Thread via GitHub
github-actions[bot] commented on PR #12216: URL: https://github.com/apache/iceberg/pull/12216#issuecomment-2722981697 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

2025-03-13 Thread via GitHub
rdblue commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r1994431295 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -543,6 +563,122 @@ public int hashCode() { } } + public static class GeometryType extends Pr

Re: [PR] Kafka Connect: Handling no coordinator and data loss in ICR mode [iceberg]

2025-03-13 Thread via GitHub
bryanck commented on code in PR #12372: URL: https://github.com/apache/iceberg/pull/12372#discussion_r1993669715 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CommitterImpl.java: ## @@ -43,6 +43,21 @@ public class CommitterImpl implements Commit

Re: [I] Provide differert read interface for reader [iceberg-rust]

2025-03-13 Thread via GitHub
ZENOTME commented on issue #1047: URL: https://github.com/apache/iceberg-rust/issues/1047#issuecomment-2722967864 > Thanks [@ZENOTME](https://github.com/ZENOTME) for raising this. I think what's missing is a `FileReader` which accepts following arguements: > > 1. File path > 2. Fil

Re: [I] Read is not working on Iceberg Hive table [iceberg]

2025-03-13 Thread via GitHub
eugeny-stoyka commented on issue #7924: URL: https://github.com/apache/iceberg/issues/7924#issuecomment-2722965252 @Aggarwal-Raghav hello, can you show your hive/tez configuration please, i'm using Iceberg Version:1.5.1 Hive version: 3.13 Hadoop Version: 3.3.6 Tez Version

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

2025-03-13 Thread via GitHub
rdblue commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r1994452758 ## core/src/test/java/org/apache/iceberg/TestSchemaUpdate.java: ## @@ -364,7 +365,11 @@ public void testUpdateFailure() { Types.FixedType.ofLength(4),

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

2025-03-13 Thread via GitHub
rdblue commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r1994449449 ## core/src/test/java/org/apache/iceberg/TestGeospatialTable.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more c

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

2025-03-13 Thread via GitHub
rdblue commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r1994451994 ## core/src/test/java/org/apache/iceberg/TestSchemaParser.java: ## @@ -142,4 +143,31 @@ public void testPrimitiveTypeDefaultValues(Type.PrimitiveType type, Literal d

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

2025-03-13 Thread via GitHub
rdblue commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r1994448507 ## core/src/main/java/org/apache/iceberg/util/GeometryUtil.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more con

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

2025-03-13 Thread via GitHub
rdblue commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r1994447450 ## build.gradle: ## @@ -348,6 +348,7 @@ project(':iceberg-core') { implementation libs.jackson.databind implementation libs.caffeine implementation libs

[I] Split manifest module into multiple modules [iceberg-rust]

2025-03-13 Thread via GitHub
jonathanc-n opened a new issue, #1083: URL: https://github.com/apache/iceberg-rust/issues/1083 ### Is your feature request related to a problem or challenge? `manifest` module has been getting quite large, can be split into multiple modules. ### Describe the solution you'd like

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

2025-03-13 Thread via GitHub
rdblue commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r1994445921 ## core/src/main/java/org/apache/iceberg/SingleValueParser.java: ## @@ -335,6 +349,13 @@ public static void toJson(Type type, Object defaultValue, JsonGenerator gener

Re: [PR] Core: Fix support for GenericManifestFile intex projection [iceberg]

2025-03-13 Thread via GitHub
rdblue commented on code in PR #12522: URL: https://github.com/apache/iceberg/pull/12522#discussion_r1994355485 ## core/src/main/java/org/apache/iceberg/GenericManifestFile.java: ## @@ -67,24 +68,10 @@ public GenericManifestFile(Schema avroSchema) { this.avroSchema = avroSc

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

2025-03-13 Thread via GitHub
rdblue commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r199312 ## core/src/main/java/org/apache/iceberg/SchemaParser.java: ## @@ -141,11 +145,39 @@ static void toJson(Types.MapType map, JsonGenerator generator) throws IOExceptio

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

2025-03-13 Thread via GitHub
rdblue commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r199116 ## core/src/main/java/org/apache/iceberg/SchemaParser.java: ## @@ -141,11 +145,39 @@ static void toJson(Types.MapType map, JsonGenerator generator) throws IOExceptio

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

2025-03-13 Thread via GitHub
rdblue commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r1994443261 ## api/src/test/java/org/apache/iceberg/types/TestTypes.java: ## @@ -90,5 +90,42 @@ public void testNestedFieldBuilderIdCheck() { assertThatExceptionOfType(NullPo

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

2025-03-13 Thread via GitHub
rdblue commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r1994436875 ## api/src/test/java/org/apache/iceberg/TestPartitionSpecValidation.java: ## @@ -327,12 +329,34 @@ public void testVariantUnsupported() { .hasMessage("Cannot

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

2025-03-13 Thread via GitHub
rdblue commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r1994441902 ## api/src/test/java/org/apache/iceberg/types/TestSerializableTypes.java: ## @@ -63,7 +63,14 @@ public void testEqualTypes() throws Exception { Types.Decima

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

2025-03-13 Thread via GitHub
rdblue commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r1994438996 ## api/src/main/java/org/apache/iceberg/types/EdgeInterpolationAlgorithm.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

2025-03-13 Thread via GitHub
rdblue commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r1994435854 ## api/src/test/java/org/apache/iceberg/TestPartitionSpecValidation.java: ## @@ -327,12 +329,34 @@ public void testVariantUnsupported() { .hasMessage("Cannot

Re: [PR] Introduce Schema update APIs [iceberg-rust]

2025-03-13 Thread via GitHub
jonathanc-n commented on PR #883: URL: https://github.com/apache/iceberg-rust/pull/883#issuecomment-2722936278 @Lordworms Are you able to refactor this implementation, there has been a few changes made since. I can review after that is done. -- This is an automated message from the Apache

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

2025-03-13 Thread via GitHub
rdblue commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r1994434710 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -543,6 +563,122 @@ public int hashCode() { } } + public static class GeometryType extends Pr

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

2025-03-13 Thread via GitHub
rdblue commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r1994433068 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -543,6 +563,122 @@ public int hashCode() { } } + public static class GeometryType extends Pr

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

2025-03-13 Thread via GitHub
rdblue commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r1994432786 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -543,6 +563,122 @@ public int hashCode() { } } + public static class GeometryType extends Pr

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

2025-03-13 Thread via GitHub
rdblue commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r1994430054 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -543,6 +563,122 @@ public int hashCode() { } } + public static class GeometryType extends Pr

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

2025-03-13 Thread via GitHub
rdblue commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r1994428251 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -543,6 +563,122 @@ public int hashCode() { } } + public static class GeometryType extends Pr

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

2025-03-13 Thread via GitHub
rdblue commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r1994426534 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -543,6 +561,120 @@ public int hashCode() { } } + public static class GeometryType extends Pr

Re: [PR] Range distribution iceberg sink [iceberg]

2025-03-13 Thread via GitHub
rodmeneses commented on PR #12071: URL: https://github.com/apache/iceberg/pull/12071#issuecomment-2722917905 keeping it alive -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

2025-03-13 Thread via GitHub
rdblue commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r1994424972 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -543,6 +563,122 @@ public int hashCode() { } } + public static class GeometryType extends Pr

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

2025-03-13 Thread via GitHub
rdblue commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r1994423648 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -70,6 +76,20 @@ public static Type fromTypeName(String typeString) { return TYPES.get(lowerTypeS

Re: [PR] Parquet: Add variant array reader in Parquet [iceberg]

2025-03-13 Thread via GitHub
rdblue commented on code in PR #12512: URL: https://github.com/apache/iceberg/pull/12512#discussion_r1994393447 ## core/src/main/java/org/apache/iceberg/variants/ShreddedArray.java: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

2025-03-13 Thread via GitHub
rdblue commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r1994421527 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -58,9 +58,15 @@ private Types() {} .put(BinaryType.get().toString(), BinaryType.get())

[PR] Build: Bump mkdocs-material from 9.6.7 to 9.6.8 [iceberg-python]

2025-03-13 Thread via GitHub
dependabot[bot] opened a new pull request, #1792: URL: https://github.com/apache/iceberg-python/pull/1792 Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.6.7 to 9.6.8. Release notes Sourced from https://github.com/squidfunk/mkdocs-material/releases";>mk

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

2025-03-13 Thread via GitHub
rdblue commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r1994410803 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -70,6 +75,20 @@ public static Type fromTypeName(String typeString) { return TYPES.get(lowerTypeS

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

2025-03-13 Thread via GitHub
rdblue commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r1994410803 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -70,6 +75,20 @@ public static Type fromTypeName(String typeString) { return TYPES.get(lowerTypeS

[PR] Build: Bump duckdb from 1.2.0 to 1.2.1 [iceberg-python]

2025-03-13 Thread via GitHub
dependabot[bot] opened a new pull request, #1793: URL: https://github.com/apache/iceberg-python/pull/1793 Bumps [duckdb](https://github.com/duckdb/duckdb) from 1.2.0 to 1.2.1. Release notes Sourced from https://github.com/duckdb/duckdb/releases";>duckdb's releases. v1.2.1 Bug

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

2025-03-13 Thread via GitHub
rdblue commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r1994402429 ## api/src/main/java/org/apache/iceberg/types/EdgeInterpolationAlgorithm.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

2025-03-13 Thread via GitHub
rdblue commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r199436 ## api/src/main/java/org/apache/iceberg/transforms/Identity.java: ## @@ -93,6 +98,9 @@ public SerializableFunction bind(Type type) { @Override public boolean c

Re: [PR] Core: Fix support for GenericManifestFile intex projection [iceberg]

2025-03-13 Thread via GitHub
rdblue commented on PR #12522: URL: https://github.com/apache/iceberg/pull/12522#issuecomment-2722780821 Look good to me when tests are passing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[PR] Name mapping [iceberg-rust]

2025-03-13 Thread via GitHub
jonathanc-n opened a new pull request, #1082: URL: https://github.com/apache/iceberg-rust/pull/1082 ## Which issue does this PR close? split up #1072 ## What changes are included in this PR? Added index by name, index by id, and create mapping ## Are these chan

Re: [PR] feat: support S3 Table Buckets with S3TablesCatalog [iceberg-python]

2025-03-13 Thread via GitHub
felixscherz commented on PR #1429: URL: https://github.com/apache/iceberg-python/pull/1429#issuecomment-2722752778 @geruh would you have another look at this PR when you have time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [I] Partition Pruning not working with different data type [iceberg]

2025-03-13 Thread via GitHub
hussein-awala commented on issue #12491: URL: https://github.com/apache/iceberg/issues/12491#issuecomment-2722803188 As far as I know, when we compare two columns, one of type string and the other of type integer, Spark (unfortunately) casts the string column to integer, and here is a PR th

Re: [PR] Add pull-request template [iceberg-python]

2025-03-13 Thread via GitHub
hussein-awala commented on code in PR #1777: URL: https://github.com/apache/iceberg-python/pull/1777#discussion_r1994351796 ## dev/.rat-excludes: ## @@ -1,3 +1,4 @@ +.github/* Review Comment: It's very strange, how `.github/*` worked and `.github/pull_request_template.md` d

Re: [PR] feat: (catalog/glue) Add support for CreateTable [iceberg-go]

2025-03-13 Thread via GitHub
dttung2905 commented on code in PR #326: URL: https://github.com/apache/iceberg-go/pull/326#discussion_r1994364080 ## catalog/glue/glue.go: ## @@ -582,3 +633,16 @@ func filterDatabaseListByType(databases []types.Database, databaseType string) [ return filtered } + +f

Re: [PR] feat: (catalog/glue) Add support for CreateTable [iceberg-go]

2025-03-13 Thread via GitHub
dttung2905 commented on code in PR #326: URL: https://github.com/apache/iceberg-go/pull/326#discussion_r1994363575 ## catalog/glue/glue_test.go: ## @@ -778,12 +781,103 @@ func TestGlueListNamespacesIntegration(t *testing.T) { } assert := require.New(t) -

Re: [I] [1.7.1] Getting java.lang.NoSuchMethodError org.apache.iceberg.util.JsonUtil.mapper() With Hive catalog [iceberg]

2025-03-13 Thread via GitHub
nryanov closed issue #12521: [1.7.1] Getting java.lang.NoSuchMethodError org.apache.iceberg.util.JsonUtil.mapper() With Hive catalog URL: https://github.com/apache/iceberg/issues/12521 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [I] [1.7.1] Getting java.lang.NoSuchMethodError org.apache.iceberg.util.JsonUtil.mapper() With Hive catalog [iceberg]

2025-03-13 Thread via GitHub
nryanov commented on issue #12521: URL: https://github.com/apache/iceberg/issues/12521#issuecomment-2722771968 Yep, it was classpath issue. Fixed by adding into fatJar instead of compileOnly dependencies for iceberg -- This is an automated message from the Apache Git Service. To respon

Re: [PR] Core: Fix support for GenericManifestFile intex projection [iceberg]

2025-03-13 Thread via GitHub
danielcweeks commented on code in PR #12522: URL: https://github.com/apache/iceberg/pull/12522#discussion_r1994320294 ## core/src/main/java/org/apache/iceberg/GenericManifestFile.java: ## @@ -67,24 +68,10 @@ public GenericManifestFile(Schema avroSchema) { this.avroSchema =

Re: [PR] Core, Spark 3.5: Apply Equality Deletes when Doing Copy on Write [iceberg]

2025-03-13 Thread via GitHub
rdblue commented on code in PR #12479: URL: https://github.com/apache/iceberg/pull/12479#discussion_r1994241463 ## core/src/main/java/org/apache/iceberg/DeleteFileIndex.java: ## @@ -541,6 +547,10 @@ private void add( } private Iterable>> deleteManifestReaders() { +

Re: [PR] AWS: Update S3 async client configurations and docs for analytics-accelerator-s3 [iceberg]

2025-03-13 Thread via GitHub
jackye1995 commented on PR #12503: URL: https://github.com/apache/iceberg/pull/12503#issuecomment-2722685256 Looks like all comments are addressed, merging, thanks @SanjayMarreddi for the work! And thanks everyone for reviewing! -- This is an automated message from the Apache Git Service.

Re: [PR] AWS: Update S3 async client configurations and docs for analytics-accelerator-s3 [iceberg]

2025-03-13 Thread via GitHub
jackye1995 merged PR #12503: URL: https://github.com/apache/iceberg/pull/12503 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] feat: `SnapshotSummary` outline [iceberg-rust]

2025-03-13 Thread via GitHub
jonathanc-n closed pull request #939: feat: `SnapshotSummary` outline URL: https://github.com/apache/iceberg-rust/pull/939 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] Core, Spark 3.5: Apply Equality Deletes when Doing Copy on Write [iceberg]

2025-03-13 Thread via GitHub
rdblue commented on code in PR #12479: URL: https://github.com/apache/iceberg/pull/12479#discussion_r1994244408 ## core/src/main/java/org/apache/iceberg/DeleteFileIndex.java: ## @@ -541,6 +547,10 @@ private void add( } private Iterable>> deleteManifestReaders() { +

Re: [PR] feat: nan_value_counts support [iceberg-rust]

2025-03-13 Thread via GitHub
feniljain commented on PR #907: URL: https://github.com/apache/iceberg-rust/pull/907#issuecomment-2722529366 Also just FYI, I have fixed few other unrelated tests in [this](https://github.com/apache/iceberg-rust/pull/907/commits/3b1d33d71034b9621ae1c5380e43883837e732f8) commit. They started

Re: [PR] feat: nan_value_counts support [iceberg-rust]

2025-03-13 Thread via GitHub
feniljain commented on PR #907: URL: https://github.com/apache/iceberg-rust/pull/907#issuecomment-2722521143 Heyo! 👋🏻 Thanks for pointing out `SchemaWithPartnerVisitor` , I had somehow missed it when initially checking for transversing mechanisms. I have shifted implementation to use

Re: [I] [1.7.1] Getting java.lang.NoSuchMethodError org.apache.iceberg.util.JsonUtil.mapper() With Hive catalog [iceberg]

2025-03-13 Thread via GitHub
nryanov commented on issue #12521: URL: https://github.com/apache/iceberg/issues/12521#issuecomment-2722409077 ``` dependencies { compileOnly libs.spark.sql compileOnly libs.spark.core compileOnly libs.spark.avro compileOnly libs.iceberg.spark.runtime com

Re: [PR] AWS: Update S3 async client configurations and docs for analytics-accelerator-s3 [iceberg]

2025-03-13 Thread via GitHub
SanjayMarreddi commented on code in PR #12503: URL: https://github.com/apache/iceberg/pull/12503#discussion_r1994120830 ## docs/docs/aws.md: ## @@ -565,6 +565,81 @@ spark-sql --conf spark.sql.catalog.my_catalog=org.apache.iceberg.spark.SparkCata For more details on using S3

Re: [I] I'm curious about the `hive.metastore.disallow.incompatible.col.type.changes` settings. [iceberg]

2025-03-13 Thread via GitHub
deniskuzZ commented on issue #9897: URL: https://github.com/apache/iceberg/issues/9897#issuecomment-2722356539 @wngus606, what version of HMS are you using, 2.3? 2.x and 3.x are EOL, v4.0 handles drop column properly. -- This is an automated message from the Apache Git Service. To resp

[I] [1.7.1] Getting java.lang.NoSuchMethodError org.apache.iceberg.util.JsonUtil.mapper() With Hive catalog [iceberg]

2025-03-13 Thread via GitHub
nryanov opened a new issue, #12521: URL: https://github.com/apache/iceberg/issues/12521 ### Query engine Spark (3.5.2), Hive metastore (hive 4.0.0) ### Question Trying to run simple job which create and insert data into an iceberg table but got an error ``` java.la

Re: [PR] feat: Add conversion from `FileMetaData` to `ParquetMetadata` [iceberg-rust]

2025-03-13 Thread via GitHub
Xuanwo commented on code in PR #1074: URL: https://github.com/apache/iceberg-rust/pull/1074#discussion_r1994104147 ## crates/iceberg/src/writer/file_writer/parquet_writer.rs: ## @@ -352,89 +354,25 @@ impl ParquetWriter { Ok(data_files) } -fn to_data_file_buil

Re: [PR] AWS: Update S3 async client configurations and docs for analytics-accelerator-s3 [iceberg]

2025-03-13 Thread via GitHub
HonahX commented on code in PR #12503: URL: https://github.com/apache/iceberg/pull/12503#discussion_r1994096171 ## docs/docs/aws.md: ## @@ -565,6 +565,81 @@ spark-sql --conf spark.sql.catalog.my_catalog=org.apache.iceberg.spark.SparkCata For more details on using S3 Accelera

Re: [I] Add more variants to `ErrorKind` [iceberg-rust]

2025-03-13 Thread via GitHub
Xuanwo commented on issue #1038: URL: https://github.com/apache/iceberg-rust/issues/1038#issuecomment-2722328079 > In that case then I think it is reasonable to make the current `ErrorKind` into a more descriptive type than a couple of discriminants (i.e. add fields to some of the variants)

Re: [I] Spark returns incorrect results when reading Parquet bloom filters created by Trino [iceberg]

2025-03-13 Thread via GitHub
huaxingao commented on issue #12458: URL: https://github.com/apache/iceberg/issues/12458#issuecomment-2722296948 @RussellSpitzer Thanks for the ping. I will take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [I] Spark returns incorrect results when reading Parquet bloom filters created by Trino [iceberg]

2025-03-13 Thread via GitHub
RussellSpitzer commented on issue #12458: URL: https://github.com/apache/iceberg/issues/12458#issuecomment-2722215874 @huaxingao just to put this on your radar since I know you've worked a bit in this area. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [I] Seeking Guidance on Upgrading Iceberg from 0.14.0 to 1.8.0 with Catalog and File Format Migration [iceberg]

2025-03-13 Thread via GitHub
RussellSpitzer commented on issue #12514: URL: https://github.com/apache/iceberg/issues/12514#issuecomment-2722236595 We don't have a specific upgrade guide here because the library is attempting to be as independent from the format as possible. This means that if your code compiles and run

Re: [PR] Spark 3.4: Backport partition spec inference in spark ADD_FILES procedure [iceberg]

2025-03-13 Thread via GitHub
bharos commented on PR #12508: URL: https://github.com/apache/iceberg/pull/12508#issuecomment-2722038824 > @bharos Any new changes here or is this a clean lift and shift? @RussellSpitzer It is clean lift, I copied the changes from 3.5 without making any change. Only minor chang

Re: [I] does iceberg support spark connect ? [iceberg]

2025-03-13 Thread via GitHub
RussellSpitzer commented on issue #12345: URL: https://github.com/apache/iceberg/issues/12345#issuecomment-2722187413 I haven't heard anyone say it doesn't, we also don't use anything that should be difficult to serialize (no rdds or whatnot). -- This is an automated message from the Apa

Re: [PR] feat: Add conversion from `FileMetaData` to `ParquetMetadata` [iceberg-rust]

2025-03-13 Thread via GitHub
jonathanc-n commented on code in PR #1074: URL: https://github.com/apache/iceberg-rust/pull/1074#discussion_r1994037025 ## Cargo.toml: ## @@ -94,6 +94,7 @@ serde_json = "1.0.138" serde_repr = "0.1.16" serde_with = "3.4" tempfile = "3.18" +thrift = "0.17.0" Review Comment:

  1   2   >