Kontinuation commented on code in PR #12346:
URL: https://github.com/apache/iceberg/pull/12346#discussion_r1994570257


##########
core/src/main/java/org/apache/iceberg/SingleValueParser.java:
##########
@@ -335,6 +349,13 @@ public static void toJson(Type type, Object defaultValue, 
JsonGenerator generato
           generator.writeString(decimalValue.toString());
         }
         break;
+      case GEOMETRY:
+      case GEOGRAPHY:

Review Comment:
   The JSON single-value serialization for geospatial types could only be used 
for initial/write default values. We found no real-world scenarios that require 
defining custom default values other than `null` for geospatial fields, so this 
WKT representation is not being used. We can leave JSON single-value 
serialization for geospatial values unimplemented and also remove JTS from 
iceberg dependency.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to