liurenjie1024 commented on code in PR #1084:
URL: https://github.com/apache/iceberg-rust/pull/1084#discussion_r1994582627
##########
crates/iceberg/src/delete_file_index.rs:
##########
@@ -94,6 +94,14 @@ impl DeleteFileIndex {
}
impl PopulatedDeleteFileIndex {
+ /// Creates a new populated delete file index from a list of delete file
contexts
+ ///
+ /// 1. The partition information is extracted from each delete file's
manifest entry.
+ /// 2. If the partition is empty and the delete file is not a positional
delete,
+ /// it is added to the `global_delees` vector
+ /// 3. Otherwise, the delete file is added to one of two hash maps based
on its content type.
+ ///
+ /// allows for fast lookup when determining which delete files apply to a
given data file
Review Comment:
```suggestion
/// Creates a new populated delete file index from a list of delete file
contexts, which
/// allows for fast lookup when determining which delete files apply to
a given data file.
///
/// 1. The partition information is extracted from each delete file's
manifest entry.
/// 2. If the partition is empty and the delete file is not a positional
delete,
/// it is added to the `global_delees` vector
/// 3. Otherwise, the delete file is added to one of two hash maps based
on its content type.
///
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
