rdblue commented on code in PR #12479:
URL: https://github.com/apache/iceberg/pull/12479#discussion_r1994244408
##########
core/src/main/java/org/apache/iceberg/DeleteFileIndex.java:
##########
@@ -541,6 +547,10 @@ private void add(
}
private Iterable<CloseableIterable<ManifestEntry<DeleteFile>>>
deleteManifestReaders() {
+ if (ignoreResiduals) {
+ dataFilter = Expressions.alwaysTrue();
Review Comment:
I also think that this should not modify the configuration state. It's fine
to interpret that configuration differently, but I don't think it should change
the state of the object when the configuration is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
