rdblue commented on code in PR #12346:
URL: https://github.com/apache/iceberg/pull/12346#discussion_r1994444116
##########
core/src/main/java/org/apache/iceberg/SchemaParser.java:
##########
@@ -141,11 +145,39 @@ static void toJson(Types.MapType map, JsonGenerator
generator) throws IOExceptio
}
static void toJson(Type.PrimitiveType primitive, JsonGenerator generator)
throws IOException {
- generator.writeString(primitive.toString());
+ switch (primitive.typeId()) {
Review Comment:
Primitives are encoded as type strings. This method should not change and
`GeometryType.toString` should produce a string that can be parsed by
`Types.fromTypeName`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
