SanjayMarreddi commented on code in PR #12503:
URL: https://github.com/apache/iceberg/pull/12503#discussion_r1994120830


##########
docs/docs/aws.md:
##########
@@ -565,6 +565,81 @@ spark-sql --conf 
spark.sql.catalog.my_catalog=org.apache.iceberg.spark.SparkCata
 
 For more details on using S3 Acceleration, please refer to [Configuring fast, 
secure file transfers using Amazon S3 Transfer 
Acceleration](https://docs.aws.amazon.com/AmazonS3/latest/userguide/transfer-acceleration.html).
 
+### S3 Analytics Accelerator
+
+The [Analytics Accelerator Library for Amazon 
S3](https://github.com/awslabs/analytics-accelerator-s3) helps you accelerate 
access to Amazon S3 data from your applications. This open-source solution 
reduces processing times and compute costs for your data analytics workloads.
+
+In order to enable S3 Analytics Accelerator Library to work in Iceberg, you 
can set the `s3.analytics-accelerator.enabled` catalog property to `true`. By 
default, this property is set to `false`.
+
+For example, to use S3 Analytics Accelerator with Spark, you can start the 
Spark SQL shell with:
+```
+spark-sql --conf 
spark.sql.catalog.my_catalog=org.apache.iceberg.spark.SparkCatalog \
+    --conf 
spark.sql.catalog.my_catalog.warehouse=s3://my-bucket2/my/key/prefix \
+    --conf spark.sql.catalog.my_catalog.type=glue \
+    --conf 
spark.sql.catalog.my_catalog.io-impl=org.apache.iceberg.aws.s3.S3FileIO \
+    --conf spark.sql.catalog.my_catalog.s3.analytics-accelerator.enabled=true
+```
+
+The Analytics Accelerator Library can work with either the [S3 CRT 
client](https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/crt-based-s3-client.html)
 or the 
[S3AsyncClient](https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/services/s3/S3AsyncClient.html).
 The library recommends that you use the S3 CRT client due to its enhanced 
connection pool management and [higher throughput on 
downloads](https://aws.amazon.com/blogs/developer/introducing-crt-based-s3-client-and-the-s3-transfer-manager-in-the-aws-sdk-for-java-2-x/).
+
+#### Client Configuration
+
+| Property               | Default | Description                               
                   |
+|------------------------|---------|--------------------------------------------------------------|
+| s3.crt.enabled         | `true`  | Controls if the S3 Async clients should 
be created using CRT |
+| s3.crt.max-concurrency | `500`   | Max concurrency for S3 CRT clients        
                   |
+
+Additional library specific configurations are organized into the following 
sections:
+
+##### Logical IO Configuration

Review Comment:
   Yeah, sorry - I thought of changing them too but was skeptical as they are 
under different level:) Updated now!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to