ebyhr commented on code in PR #12511:
URL: https://github.com/apache/iceberg/pull/12511#discussion_r1994659921
##########
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcViewCatalog.java:
##########
@@ -138,4 +142,50 @@ public void testCommitExceptionWithMessage() {
.hasMessageStartingWith("View already exists: " + identifier);
}
}
+
+ @Test
+ public void dropViewShouldNotDropMetadataFileIfGcNotEnabled() throws
IOException {
Review Comment:
Why not add these tests to `ViewCatalogTests`?
Can we add `test` prefix for consistency with other test methods? Also,
`throws IOException` is redundant.
Same for another test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
