rdblue commented on code in PR #12346:
URL: https://github.com/apache/iceberg/pull/12346#discussion_r1994451994
##########
core/src/test/java/org/apache/iceberg/TestSchemaParser.java:
##########
@@ -142,4 +143,31 @@ public void
testPrimitiveTypeDefaultValues(Type.PrimitiveType type, Literal<?> d
assertThat(serialized.findField("col_with_default").writeDefault())
.isEqualTo(defaultValue.value());
}
+
+ @Test
+ public void testVariantType() throws IOException {
Review Comment:
This is tested because `supportsVariantType` at the top is true. I would use
the same pattern for spatial types, adding them to the list in `DataTest` and
disabling the tests with a `supports` method. That way we can slowly add
support and enable the tests (as we are doing for unknown, variant, and
timestamp(9)).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
