Kontinuation commented on code in PR #12346:
URL: https://github.com/apache/iceberg/pull/12346#discussion_r1994552835
##########
api/src/test/java/org/apache/iceberg/types/TestSerializableTypes.java:
##########
@@ -63,7 +63,14 @@ public void testEqualTypes() throws Exception {
Types.DecimalType.of(9, 3),
Types.DecimalType.of(11, 0),
Types.FixedType.ofLength(4),
- Types.FixedType.ofLength(34)
+ Types.FixedType.ofLength(34),
+ Types.GeometryType.get(),
+ Types.GeometryType.of("srid:3857"),
+ Types.GeometryType.of("projjson:Test_Identifier"),
Review Comment:
PrimitiveTypes are serialized and deserialized using `toString` and
`fromTypeString`, since PrimitiveType has implemented `Object writeReplace()`
method to handle Java serialization. Type parameters do affect how primitive
types are serialized and deserialized.
A better place for such tests could be `TestTypes.java`, but I think that
having tests here to ensure round-trip type consistency also makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
