feniljain commented on PR #907: URL: https://github.com/apache/iceberg-rust/pull/907#issuecomment-2722521143
Heyo! 👋🏻 Thanks for pointing out `SchemaWithPartnerVisitor` , I had somehow missed it when initially checking for transversing mechanisms. I have shifted implementation to use this :) Also, I have one small doubt, is [this](https://github.com/feniljain/iceberg-rust/blob/3b1d33d71034b9621ae1c5380e43883837e732f8/crates/iceberg/src/writer/file_writer/parquet_writer.rs#L526) `clone` okay? [`RecordBatch`](https://github.com/apache/arrow-rs/blob/172d79fa55158eed1ec3ea34f7941f1349a94a9d/arrow-array/src/record_batch.rs#L199-L208) has three fields: - `schema` which is `SchemaRef` i.e. behind `Arc`, this is a cheap clone - `columns` which is `Vec<Arc<dyn Array>>`, here vector will be cloned, but internally buffers seem to be behind `Arc`, so even that should cheap to clone - `row_count` is a primitive usize type, not a problem This was my thinking when using `clone`, but do lemme know if I am misunderstanding something here and if there's a better way, thanks! 🙇🏻 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
