Re: [PR] Spark: Fix SparkTable to use name and effective snapshotID for comparing [iceberg]

2024-02-01 Thread via GitHub
wooyeong commented on code in PR #9455: URL: https://github.com/apache/iceberg/pull/9455#discussion_r1475693223 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkTable.java: ## @@ -53,4 +54,68 @@ public void testTableEquality() throws NoSuchTableExceptio

Re: [PR] Spark: Fix SparkTable to use name and effective snapshotID for comparing [iceberg]

2024-02-01 Thread via GitHub
wooyeong commented on code in PR #9455: URL: https://github.com/apache/iceberg/pull/9455#discussion_r1475687874 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java: ## @@ -131,12 +133,12 @@ public SparkTable(Table icebergTable, boolean refreshEager

Re: [PR] Spark: Fix SparkTable to use name and effective snapshotID for comparing [iceberg]

2024-02-01 Thread via GitHub
wooyeong commented on code in PR #9455: URL: https://github.com/apache/iceberg/pull/9455#discussion_r1475687874 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java: ## @@ -131,12 +133,12 @@ public SparkTable(Table icebergTable, boolean refreshEager

Re: [PR] Create ExtensionTestBase for migration to JUnit5 [iceberg]

2024-02-01 Thread via GitHub
tomtongue commented on code in PR #9613: URL: https://github.com/apache/iceberg/pull/9613#discussion_r1475691097 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java: ## @@ -489,10 +479,10 @@ public void addPartitionToParti

Re: [PR] Spark: Fix SparkTable to use name and effective snapshotID for comparing [iceberg]

2024-02-01 Thread via GitHub
wooyeong commented on code in PR #9455: URL: https://github.com/apache/iceberg/pull/9455#discussion_r1475687874 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java: ## @@ -131,12 +133,12 @@ public SparkTable(Table icebergTable, boolean refreshEager

Re: [PR] Spark: Fix SparkTable to use name and effective snapshotID for comparing [iceberg]

2024-02-01 Thread via GitHub
wooyeong commented on code in PR #9455: URL: https://github.com/apache/iceberg/pull/9455#discussion_r1475682472 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java: ## @@ -117,7 +119,7 @@ public class SparkTable .build(); private fin

Re: [PR] Spark: Fix SparkTable to use name and effective snapshotID for comparing [iceberg]

2024-02-01 Thread via GitHub
wooyeong commented on code in PR #9455: URL: https://github.com/apache/iceberg/pull/9455#discussion_r1475681223 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java: ## @@ -131,12 +133,12 @@ public SparkTable(Table icebergTable, boolean refreshEager

Re: [PR] Spark 3.4: Read deletes in parallel and cache them on executors [iceberg]

2024-02-01 Thread via GitHub
aokolnychyi commented on code in PR #9603: URL: https://github.com/apache/iceberg/pull/9603#discussion_r1475678909 ## spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/TestSparkExecutorCache.java: ## @@ -0,0 +1,444 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] Spark 3.4: Read deletes in parallel and cache them on executors [iceberg]

2024-02-01 Thread via GitHub
aokolnychyi commented on code in PR #9603: URL: https://github.com/apache/iceberg/pull/9603#discussion_r1475678909 ## spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/TestSparkExecutorCache.java: ## @@ -0,0 +1,444 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] Spark 3.5: Add deleted_snapshots_count to result of expire_snapshots procedure [iceberg]

2024-02-01 Thread via GitHub
manuzhang commented on code in PR #9605: URL: https://github.com/apache/iceberg/pull/9605#discussion_r1475670135 ## core/src/main/java/org/apache/iceberg/RemoveSnapshots.java: ## @@ -313,6 +317,11 @@ public void commit() { } } + @Override + public long expiredSnapsho

Re: [PR] feat: add parquet writer [iceberg-rust]

2024-02-01 Thread via GitHub
liurenjie1024 commented on code in PR #176: URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1475635301 ## crates/iceberg/src/writer/file_writer/location_generator.rs: ## @@ -0,0 +1,251 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

Re: [PR] feat: add parquet writer [iceberg-rust]

2024-02-01 Thread via GitHub
ZENOTME commented on code in PR #176: URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1475621034 ## crates/iceberg/src/writer/file_writer/location_generator.rs: ## @@ -0,0 +1,251 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contr

Re: [PR] Core: HadoopTable needs to skip file cleanup after task failure under some boundary conditions. [iceberg]

2024-02-01 Thread via GitHub
BsoBird commented on PR #9546: URL: https://github.com/apache/iceberg/pull/9546#issuecomment-1923010354 @RussellSpitzer Hello Sir. I resubmitted the code. Please check my implementation of this version. -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] feat: add parquet writer [iceberg-rust]

2024-02-01 Thread via GitHub
ZENOTME commented on code in PR #176: URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1475596750 ## crates/iceberg/src/error.rs: ## @@ -44,6 +44,9 @@ pub enum ErrorKind { /// /// This error is returned when given iceberg feature is not supported.

Re: [PR] Core: Supports limiting the count of manifests to merge when committing [iceberg]

2024-02-01 Thread via GitHub
ConeyLiu commented on code in PR #9609: URL: https://github.com/apache/iceberg/pull/9609#discussion_r1475596616 ## core/src/main/java/org/apache/iceberg/ManifestMergeManager.java: ## @@ -148,11 +167,13 @@ private Iterable mergeGroup( // if the number of manifests

Re: [PR] feat: add parquet writer [iceberg-rust]

2024-02-01 Thread via GitHub
liurenjie1024 commented on code in PR #176: URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1475593785 ## crates/iceberg/src/error.rs: ## @@ -44,6 +44,9 @@ pub enum ErrorKind { /// /// This error is returned when given iceberg feature is not supported.

Re: [PR] feat: add parquet writer [iceberg-rust]

2024-02-01 Thread via GitHub
ZENOTME commented on code in PR #176: URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1475592171 ## crates/iceberg/src/error.rs: ## @@ -44,6 +44,9 @@ pub enum ErrorKind { /// /// This error is returned when given iceberg feature is not supported.

Re: [PR] feat: add parquet writer [iceberg-rust]

2024-02-01 Thread via GitHub
liurenjie1024 commented on code in PR #176: URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1475583716 ## crates/iceberg/src/writer/file_writer/location_generator.rs: ## @@ -0,0 +1,251 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

Re: [PR] feat: add parquet writer [iceberg-rust]

2024-02-01 Thread via GitHub
liurenjie1024 commented on code in PR #176: URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1475581238 ## crates/iceberg/src/writer/file_writer/parquet_writer.rs: ## @@ -0,0 +1,390 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more con

Re: [PR] feat: add parquet writer [iceberg-rust]

2024-02-01 Thread via GitHub
liurenjie1024 commented on code in PR #176: URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1475578608 ## crates/iceberg/src/error.rs: ## @@ -44,6 +44,9 @@ pub enum ErrorKind { /// /// This error is returned when given iceberg feature is not supported.

Re: [I] Add runtime module to enable concurrent load of manifest files. [iceberg-rust]

2024-02-01 Thread via GitHub
liurenjie1024 commented on issue #124: URL: https://github.com/apache/iceberg-rust/issues/124#issuecomment-1922889772 > Hi, is this what you refer to? Yes, exactly. > Can you plz explain more about "careful to runtime agnostic"? Is there anything we need to be careful when impl

Re: [PR] Partition Evolution [iceberg-python]

2024-02-01 Thread via GitHub
amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1475572593 ## pyiceberg/table/__init__.py: ## @@ -2271,3 +2317,244 @@ def commit(self) -> Snapshot: ) return snapshot + + +class UpdateSpec:

Re: [PR] Partition Evolution [iceberg-python]

2024-02-01 Thread via GitHub
amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1475572378 ## pyiceberg/table/__init__.py: ## @@ -2271,3 +2325,240 @@ def commit(self) -> Snapshot: ) return snapshot + + +class UpdateSpec:

Re: [PR] Partition Evolution [iceberg-python]

2024-02-01 Thread via GitHub
amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1475571056 ## tests/test_integration_partition_evolution.py: ## @@ -0,0 +1,397 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributo

Re: [PR] Partition Evolution [iceberg-python]

2024-02-01 Thread via GitHub
amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1475571056 ## tests/test_integration_partition_evolution.py: ## @@ -0,0 +1,397 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributo

Re: [PR] Partition Evolution [iceberg-python]

2024-02-01 Thread via GitHub
amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1475567295 ## pyiceberg/table/__init__.py: ## @@ -868,6 +919,12 @@ def sort_orders(self) -> Dict[int, SortOrder]: """Return a dict of the sort orders of thi

Re: [PR] Partition Evolution [iceberg-python]

2024-02-01 Thread via GitHub
amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1475565719 ## pyiceberg/table/__init__.py: ## @@ -533,6 +551,39 @@ def _(update: SetCurrentSchemaUpdate, base_metadata: TableMetadata, context: _Ta return base

Re: [PR] Partition Evolution [iceberg-python]

2024-02-01 Thread via GitHub
amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1475565567 ## pyiceberg/table/__init__.py: ## @@ -2271,3 +2331,241 @@ def commit(self) -> Snapshot: ) return snapshot + + +class UpdateSpec:

Re: [PR] Improve error message in case of a mismatch [iceberg-python]

2024-02-01 Thread via GitHub
HonahX commented on code in PR #352: URL: https://github.com/apache/iceberg-python/pull/352#discussion_r1475415226 ## pyiceberg/schema.py: ## @@ -221,6 +227,11 @@ def find_type(self, name_or_id: Union[str, int], case_sensitive: bool = True) -> def highest_field_id(self) ->

Re: [I] Support partitioned writes [iceberg-python]

2024-02-01 Thread via GitHub
jqin61 commented on issue #208: URL: https://github.com/apache/iceberg-python/issues/208#issuecomment-1922851143 Opened draft PR with working code samples (it supports partitioned append with identity transform for now): https://github.com/apache/iceberg-python/pull/353 -- This is an aut

[PR] partitioned write support [iceberg-python]

2024-02-01 Thread via GitHub
jqin61 opened a new pull request, #353: URL: https://github.com/apache/iceberg-python/pull/353 Todo - [ ] support partitioned append() - [x] support append with identity transform - [ ] fix scenario when arrow table schema not aligned with iceberg schema - [ ] add integrat

Re: [PR] Partition Evolution [iceberg-python]

2024-02-01 Thread via GitHub
amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1475530412 ## pyiceberg/table/__init__.py: ## @@ -2271,3 +2317,244 @@ def commit(self) -> Snapshot: ) return snapshot + + +class UpdateSpec:

Re: [I] Add runtime module to enable concurrent load of manifest files. [iceberg-rust]

2024-02-01 Thread via GitHub
odysa commented on issue #124: URL: https://github.com/apache/iceberg-rust/issues/124#issuecomment-1922745247 Hi, is this what you refer to? Can you plz explain more about "careful to runtime agnostic"? Is there anything we need to be careful when implementing concurrent scanning? https

Re: [PR] feat: add parquet writer [iceberg-rust]

2024-02-01 Thread via GitHub
ZENOTME commented on code in PR #176: URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1475452336 ## crates/iceberg/src/writer/file_writer/parquet_writer.rs: ## @@ -0,0 +1,390 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribut

Re: [PR] feat: add parquet writer [iceberg-rust]

2024-02-01 Thread via GitHub
ZENOTME commented on code in PR #176: URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1475451458 ## crates/iceberg/src/writer/file_writer/parquet_writer.rs: ## @@ -0,0 +1,390 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribut

Re: [PR] feat: add parquet writer [iceberg-rust]

2024-02-01 Thread via GitHub
ZENOTME commented on code in PR #176: URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1475447615 ## crates/iceberg/src/writer/file_writer/parquet_writer.rs: ## @@ -0,0 +1,390 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribut

Re: [PR] feat: add parquet writer [iceberg-rust]

2024-02-01 Thread via GitHub
ZENOTME commented on code in PR #176: URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1475446762 ## crates/iceberg/src/writer/file_writer/location_generator.rs: ## @@ -0,0 +1,251 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contr

Re: [PR] Spark 3.5: Support executor cache locality [iceberg]

2024-02-01 Thread via GitHub
advancedxy commented on code in PR #9563: URL: https://github.com/apache/iceberg/pull/9563#discussion_r1475446827 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPlanningUtil.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] Spark 3.5: Support executor cache locality [iceberg]

2024-02-01 Thread via GitHub
advancedxy commented on code in PR #9563: URL: https://github.com/apache/iceberg/pull/9563#discussion_r1475440771 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMergeOnReadDelete.java: ## @@ -85,6 +86,30 @@ public static void clearTestSparkC

Re: [PR] feat: add parquet writer [iceberg-rust]

2024-02-01 Thread via GitHub
ZENOTME commented on code in PR #176: URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1475440018 ## crates/iceberg/src/error.rs: ## @@ -44,6 +44,9 @@ pub enum ErrorKind { /// /// This error is returned when given iceberg feature is not supported.

Re: [PR] Spark 3.5: Support executor cache locality [iceberg]

2024-02-01 Thread via GitHub
advancedxy commented on code in PR #9563: URL: https://github.com/apache/iceberg/pull/9563#discussion_r1475438902 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkReadConf.java: ## @@ -331,4 +331,24 @@ private long driverMaxResultSize() { SparkConf sparkConf

Re: [I] Add instructions on updating `doap.rdf` in the how-to-release guide [iceberg]

2024-02-01 Thread via GitHub
ajantha-bhat commented on issue #9522: URL: https://github.com/apache/iceberg/issues/9522#issuecomment-1922661927 @jbonofre: Thanks. I have assigned the issue to you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] Small simplification in the name-mapping [iceberg-python]

2024-02-01 Thread via GitHub
HonahX merged PR #351: URL: https://github.com/apache/iceberg-python/pull/351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] Improve error message in case of a mismatch [iceberg-python]

2024-02-01 Thread via GitHub
HonahX commented on code in PR #352: URL: https://github.com/apache/iceberg-python/pull/352#discussion_r1475415226 ## pyiceberg/schema.py: ## @@ -221,6 +227,11 @@ def find_type(self, name_or_id: Union[str, int], case_sensitive: bool = True) -> def highest_field_id(self) ->

Re: [I] Core: complete FileScanTaskParser for other FileScanTask implementation classes (like StaticDataTask) [iceberg]

2024-02-01 Thread via GitHub
stevenzwu commented on issue #9597: URL: https://github.com/apache/iceberg/issues/9597#issuecomment-1922601810 @nastra thanks for the comments! Regarding the JSON format, we are on the same page of adding a new `task-type` or `type` field. Are you suggesting adding a new API

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-02-01 Thread via GitHub
danielcweeks commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1475391895 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java: ## @@ -245,13 +286,18 @@ public List listTables(Namespace namespace) { row ->

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-02-01 Thread via GitHub
danielcweeks commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1475388391 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcViewOperations.java: ## @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-02-01 Thread via GitHub
danielcweeks commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1475378129 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java: ## @@ -303,7 +330,152 @@ public static Properties filterAndRemovePrefix(Map properties, S return

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-02-01 Thread via GitHub
danielcweeks commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1475376446 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcTableOperations.java: ## @@ -71,7 +68,7 @@ public void doRefresh() { Map table; try { - table =

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-02-01 Thread via GitHub
danielcweeks commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1475366557 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcTableOperations.java: ## @@ -71,7 +68,7 @@ public void doRefresh() { Map table; try { - table =

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-02-01 Thread via GitHub
danielcweeks commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1475366557 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcTableOperations.java: ## @@ -71,7 +68,7 @@ public void doRefresh() { Map table; try { - table =

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-02-01 Thread via GitHub
danielcweeks commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1475365294 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcTableOperations.java: ## @@ -182,18 +169,13 @@ private void createTable(String newMetadataLocation) throws SQLEx

Re: [PR] Spark 3.4: Read deletes in parallel and cache them on executors [iceberg]

2024-02-01 Thread via GitHub
szehon-ho commented on code in PR #9603: URL: https://github.com/apache/iceberg/pull/9603#discussion_r1475361443 ## spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/TestSparkExecutorCache.java: ## @@ -0,0 +1,444 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-02-01 Thread via GitHub
danielcweeks commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1475359184 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java: ## @@ -503,6 +550,84 @@ public boolean namespaceExists(Namespace namespace) { return JdbcUtil.

Re: [I] Spark based functional test-cases [iceberg]

2024-02-01 Thread via GitHub
github-actions[bot] commented on issue #116: URL: https://github.com/apache/iceberg/issues/116#issuecomment-1922529577 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Git

Re: [I] ORC does not use InputFile and OutputFile abstractions [iceberg]

2024-02-01 Thread via GitHub
github-actions[bot] closed issue #96: ORC does not use InputFile and OutputFile abstractions URL: https://github.com/apache/iceberg/issues/96 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [I] Encryption KeyManager implementation that is backed by KMS [iceberg]

2024-02-01 Thread via GitHub
github-actions[bot] commented on issue #81: URL: https://github.com/apache/iceberg/issues/81#issuecomment-1922529534 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Git Se

Re: [I] Additional Metrics and Statistics [iceberg]

2024-02-01 Thread via GitHub
github-actions[bot] commented on issue #76: URL: https://github.com/apache/iceberg/issues/76#issuecomment-1922529516 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Git Se

Re: [I] Support cryptographic integrity [iceberg]

2024-02-01 Thread via GitHub
github-actions[bot] commented on issue #44: URL: https://github.com/apache/iceberg/issues/44#issuecomment-1922529496 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Git Se

Re: [I] Add an API to maintain external schema mappings [iceberg]

2024-02-01 Thread via GitHub
github-actions[bot] commented on issue #41: URL: https://github.com/apache/iceberg/issues/41#issuecomment-1922529470 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Git Se

Re: [I] ORC does not support Iceberg generics [iceberg]

2024-02-01 Thread via GitHub
github-actions[bot] commented on issue #127: URL: https://github.com/apache/iceberg/issues/127#issuecomment-1922529619 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Git

Re: [I] ORC does not support Iceberg generics [iceberg]

2024-02-01 Thread via GitHub
github-actions[bot] closed issue #127: ORC does not support Iceberg generics URL: https://github.com/apache/iceberg/issues/127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [I] Support plaintext Data (CSV, TSV, etc.) in Iceberg Tables [iceberg]

2024-02-01 Thread via GitHub
github-actions[bot] closed issue #118: Support plaintext Data (CSV, TSV, etc.) in Iceberg Tables URL: https://github.com/apache/iceberg/issues/118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Support plaintext Data (CSV, TSV, etc.) in Iceberg Tables [iceberg]

2024-02-01 Thread via GitHub
github-actions[bot] commented on issue #118: URL: https://github.com/apache/iceberg/issues/118#issuecomment-1922529593 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Git

Re: [I] ORC does not use InputFile and OutputFile abstractions [iceberg]

2024-02-01 Thread via GitHub
github-actions[bot] commented on issue #96: URL: https://github.com/apache/iceberg/issues/96#issuecomment-1922529558 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Git Se

Re: [I] Spark based functional test-cases [iceberg]

2024-02-01 Thread via GitHub
github-actions[bot] closed issue #116: Spark based functional test-cases URL: https://github.com/apache/iceberg/issues/116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [I] Encryption KeyManager implementation that is backed by KMS [iceberg]

2024-02-01 Thread via GitHub
github-actions[bot] closed issue #81: Encryption KeyManager implementation that is backed by KMS URL: https://github.com/apache/iceberg/issues/81 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Additional Metrics and Statistics [iceberg]

2024-02-01 Thread via GitHub
github-actions[bot] closed issue #76: Additional Metrics and Statistics URL: https://github.com/apache/iceberg/issues/76 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [I] Support cryptographic integrity [iceberg]

2024-02-01 Thread via GitHub
github-actions[bot] closed issue #44: Support cryptographic integrity URL: https://github.com/apache/iceberg/issues/44 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [I] Add an API to maintain external schema mappings [iceberg]

2024-02-01 Thread via GitHub
github-actions[bot] closed issue #41: Add an API to maintain external schema mappings URL: https://github.com/apache/iceberg/issues/41 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Spark 3.4: Extend action for rewriting manifests to support deletes [iceberg]

2024-02-01 Thread via GitHub
aokolnychyi merged PR #9616: URL: https://github.com/apache/iceberg/pull/9616 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-02-01 Thread via GitHub
danielcweeks commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1475337646 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java: ## @@ -245,13 +286,18 @@ public List listTables(Namespace namespace) { row ->

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-02-01 Thread via GitHub
danielcweeks commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1475329370 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java: ## @@ -80,10 +83,11 @@ public class JdbcCatalog extends BaseMetastoreCatalog private final Funct

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-01 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1475300294 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SchemaUtils.java: ## @@ -0,0 +1,375 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-01 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1475298017 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SchemaUtils.java: ## @@ -0,0 +1,375 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-01 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1475297691 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SchemaUtils.java: ## @@ -0,0 +1,375 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-01 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1475296932 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SchemaUtils.java: ## @@ -0,0 +1,375 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-01 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1475296279 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SchemaUtils.java: ## @@ -0,0 +1,375 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-01 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1475294454 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SchemaUtils.java: ## @@ -0,0 +1,375 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-01 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1475293606 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SchemaUtils.java: ## @@ -0,0 +1,375 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-01 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1475293311 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SchemaUtils.java: ## @@ -0,0 +1,375 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-01 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1475292656 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SchemaUtils.java: ## @@ -0,0 +1,375 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-01 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1475291920 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SchemaUtils.java: ## @@ -0,0 +1,375 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-01 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1475291601 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SchemaUtils.java: ## @@ -0,0 +1,375 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Spark 3.5: Add deleted_snapshots_count to result of expire_snapshots procedure [iceberg]

2024-02-01 Thread via GitHub
aokolnychyi commented on code in PR #9605: URL: https://github.com/apache/iceberg/pull/9605#discussion_r1475287123 ## core/src/main/java/org/apache/iceberg/RemoveSnapshots.java: ## @@ -313,6 +317,11 @@ public void commit() { } } + @Override + public long expiredSnaps

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-01 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1475290713 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SchemaUtils.java: ## @@ -0,0 +1,375 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Spark 3.5: Add deleted_snapshots_count to result of expire_snapshots procedure [iceberg]

2024-02-01 Thread via GitHub
aokolnychyi commented on code in PR #9605: URL: https://github.com/apache/iceberg/pull/9605#discussion_r1475290568 ## api/src/main/java/org/apache/iceberg/ExpireSnapshots.java: ## @@ -118,4 +118,9 @@ public interface ExpireSnapshots extends PendingUpdate> { * @return this f

Re: [PR] Spark 3.5: Add deleted_snapshots_count to result of expire_snapshots procedure [iceberg]

2024-02-01 Thread via GitHub
aokolnychyi commented on code in PR #9605: URL: https://github.com/apache/iceberg/pull/9605#discussion_r1475287123 ## core/src/main/java/org/apache/iceberg/RemoveSnapshots.java: ## @@ -313,6 +317,11 @@ public void commit() { } } + @Override + public long expiredSnaps

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-01 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1475285952 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/IcebergWriter.java: ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-01 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1475284866 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/IcebergWriterFactory.java: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-01 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1475279732 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/IcebergWriterFactory.java: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] Flink: Backport #9364 to 1.16 and 1.17 for Create CatalogTestBase for migration to JUnit5 [iceberg]

2024-02-01 Thread via GitHub
rodmeneses commented on PR #9601: URL: https://github.com/apache/iceberg/pull/9601#issuecomment-1922436989 thanks so much for the review @pvary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Flink: Adds the ability to read from a branch on the Flink Iceberg Source [iceberg]

2024-02-01 Thread via GitHub
rodmeneses commented on PR #9547: URL: https://github.com/apache/iceberg/pull/9547#issuecomment-1922436526 Thanks so much for the review @stevenzwu and @pvary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] Spark 3.4: Read deletes in parallel and cache them on executors [iceberg]

2024-02-01 Thread via GitHub
aokolnychyi commented on code in PR #9603: URL: https://github.com/apache/iceberg/pull/9603#discussion_r1475275241 ## spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestSparkExecutorCache.java: ## @@ -0,0 +1,366 @@ +/* + * Licensed to the Apache So

Re: [PR] Spark: Fix SparkTable to use name and effective snapshotID for comparing [iceberg]

2024-02-01 Thread via GitHub
aokolnychyi commented on code in PR #9455: URL: https://github.com/apache/iceberg/pull/9455#discussion_r1475249277 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkTable.java: ## @@ -53,4 +54,68 @@ public void testTableEquality() throws NoSuchTableExcep

Re: [PR] Spark: Fix SparkTable to use name and effective snapshotID for comparing [iceberg]

2024-02-01 Thread via GitHub
aokolnychyi commented on code in PR #9455: URL: https://github.com/apache/iceberg/pull/9455#discussion_r1475245547 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java: ## @@ -405,15 +407,18 @@ public boolean equals(Object other) { return fals

Re: [PR] Bug fix for writing empty df or null only columns [iceberg-python]

2024-02-01 Thread via GitHub
Fokko merged PR #350: URL: https://github.com/apache/iceberg-python/pull/350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [I] `update_{min,max}` fail if `val` is None [iceberg-python]

2024-02-01 Thread via GitHub
Fokko closed issue #337: `update_{min,max}` fail if `val` is None URL: https://github.com/apache/iceberg-python/issues/337 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [I] Support Null Column Write in Unpartitioned Table [iceberg-python]

2024-02-01 Thread via GitHub
Fokko closed issue #348: Support Null Column Write in Unpartitioned Table URL: https://github.com/apache/iceberg-python/issues/348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] Bug fix for writing empty df or null only columns [iceberg-python]

2024-02-01 Thread via GitHub
syun64 commented on code in PR #350: URL: https://github.com/apache/iceberg-python/pull/350#discussion_r1475221887 ## pyiceberg/table/__init__.py: ## @@ -946,10 +946,13 @@ def append(self, df: pa.Table) -> None: if len(self.sort_order().fields) > 0: raise V

  1   2   3   >