ZENOTME commented on code in PR #176: URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1475592171
########## crates/iceberg/src/error.rs: ########## @@ -44,6 +44,9 @@ pub enum ErrorKind { /// /// This error is returned when given iceberg feature is not supported. FeatureUnsupported, + /// Iceberg meets an unexpected parameter. Please refer the related doc or error message to + /// check if the parameter is valid. + UnexpectedParameter, Review Comment: Oh, do you means that `ErrorKind` is used to identify the way to handle the error? For `Unexpect`, it means that iceberg can't handle this error and just return it. (I don't have a clear definition of what `ErrorKind` used to identify. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org